Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display word, character count on overflow menu Action Sheet #506

Closed
iamthomasbishop opened this issue Jan 26, 2019 · 2 comments · Fixed by #2380, wordpress-mobile/WordPress-iOS#14305, wordpress-mobile/WordPress-Android#12186 or #2391
Assignees
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile HACK week HACK week June 2020 [Pri] Medium Proposal [Status] Needs Research [Type] Enhancement Improves a current area of the editor

Comments

@iamthomasbishop
Copy link
Contributor

On Aztec iOS, we recently added word and character counts as a description to the Action Sheet that is shown when pressing on the ••• menu. I'd prefer to maintain this in the same location for Gutenberg if possible. For reference:

img_1647 trim 2019-01-25 22_57_23

Note: I'm not sure if/how we inherit this type of Aztec improvement in parallel, but I'd like to make sure we maintain them if possible for the sake of user expectations.

@koke
Copy link
Member

koke commented Jan 28, 2019

I'm not sure if/how we inherit this type of Aztec improvement in parallel

From what I can see, "sort of" 😁 The action sheet code actually has the title code there but commented out for Gutenberg, since it's the responsibility of either Gutenberg or Aztec to count the words. Gutenberg already has this functionality since it shows a word count in the TOC, we'd just need to connect the right things.

@rezzap
Copy link

rezzap commented Mar 5, 2020

We have had a few users requesting this or getting confused with it not showing in the same way for both editors. The latest report is in 2755136-zen.

@SergioEstevao SergioEstevao self-assigned this May 3, 2020
@SergioEstevao SergioEstevao changed the title iOS - Display word, character count on overflow menu Action Sheet Display word, character count on overflow menu Action Sheet May 4, 2020
@SergioEstevao SergioEstevao added [Type] Enhancement Improves a current area of the editor Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile and removed [OS] iOS labels May 4, 2020
@hypest hypest added the HACK week HACK week June 2020 label Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment