-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display content information metrics #12191
Display content information metrics #12191
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
(replying to this comment)
👋 @iamthomasbishop , to answer the same for Android, it won't be very easy because we don't currently support plural variants on GlotPress. We usually workaround that by having two separate strings defined, one for singular and one for plural. Thing is, in the sentence at hand, there are three numbers that can individually be singular or plural and even though we could concatenate them as three separate sections, that's not recommended as we can't be sure if it will be correct for all locales. It's better to send the full sentence to the translators, but that will mean we'll need some complex logic to define and use those strings. Not sure it's worth it. Instead, and again talking about the WPAndroid case where I've implemented the popup dialog design, what do you think about using plurals only but formatting the whole string like this:
I think that would read OK for numbers being |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this in terms of functionality in the main apps and it's working great!
I will leave it to @mchowning to check the code.
Make the strings used uniform with iOS and web.
Expands #12186 to include the WPAndroid UI to get and show the content information metrics.
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2383
Follows this design, shared by @iamthomasbishop over Slack:
Changes introduced:
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.