Detekt Integration - Phase.3

[ParaskP7]

Related #13996
Phase.2 #14011

This issue is about integrating Detekt, phase by phase, into the WordPress-Android codebase.

Phase.1 was actually adding Detekt alongside its default behavior into the WordPress-Android codebase. This relates #13996 PR is responsible for that.

Phase.2 is all about fine-tuning the default rules to utilise Detekt as much as possible.

This Phase.3 will be about decommissioning KtLint in favor of Detekt. Below in a list of thinks to keep in mind:

1. When Detekt gets merged into develop and every developer start utilising this tool, whenever someone notices an inconsistency between KtLint and Detekt, then this should be reported here. For example KtLint might report ForbiddenImport, while Detekt might not. This should be reported in this issue so that when KtLint ends up being decommissioned, every rule that was applicable with KtLint will still be application through Detekt.
2. When the decommission process for KtLint starts, the responsible person should traverse all the existing KtLint rules and make sure that those are being transferred to Detekt. Step no.1 about would help with that but still there might be cases where some rules might still required to be ported from KtLint to Detekt.

[stale]

This issue has been marked as stale because:

• It has been inactive for the past year.
• It isn't in a project or a milestone.
• It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

[ParaskP7]

This issue is still valid. Actually @RenanLukas posted a P2 post about removing KtLint and keep only Detekt, which is the main purpose of this phase. As such, this removal will happen sooner than later for this repo.

For more info see: paqN3M-v8-p2