Remove ktlint

[ovitrif]

Fixes #14012

Why?

• Ktlint is no friend of the @composable annotation on parameters (see paqN3M-v8-p2), and we plan to start adopting Jetpack Compose for building UIs.

• We also have a point on the Android Roadmap (see paqN3M-C6-p2) to remove KtLint in favor of Detekt.

📃 Changes:

• Remove ktlint task from CI (buildkite pipeline)
• Remove ktlint configuration & dependency
• Update coding-style doc to suggest using detekt instead of ktlint
• Remove ktlint comments for rules suppression

🧪 To test:

• Locate the Detekt-related pipeline job in Buildkite and expect success.

⚠️ Merge Instructions:

• Make sure @wordpress-mobile/owl-team approved the PR (@ParaskP7).
• Remove the 🔴 Not Ready for Merge status label.
• @ParaskP7 will have to delete the buildkite/wordpress-android/ktlint branch protection rule on trunk.
• CI should be 🟢 now.
• Merge 🚀.

Regression Notes

1. Potential unintended areas of impact
   N/a

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N/a

3. What automated tests I added (or what prevented me from doing so)
   N/a

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[wpmobilebot]

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16828-0bcfc7e.apk), or scanning this QR code:

[wpmobilebot]

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16828-0bcfc7e.apk), or scanning this QR code:

[ParaskP7]

👋 @ovitrif !

Thank you so much for re-creating this PR. As per the previous PR, I have reviewed and tested this PR as per the description, everything works as expected. 👍

[ovitrif]

👋 @ovitrif !

Thank you so much for re-creating this PR. As per the previous PR, I have reviewed and tested this PR as per the description, everything works as expected. 👍

Thank you @ParaskP7 for reviewing and helping with getting this right 🙇 ❤️ 🚀

[ParaskP7]

👋 @ovitrif !

Once more thank you so much for working on removing KtLint from WPAndroid, we are finally free! 🎉

To follow up on the merge could you also:

1. Create an Apps Platform Request for the Detekt Upgrade work. PS: The details you added here is a good summary.
2. Close Remove ktlint & update detekt to 1.19.0 #16819 in favor of this PR and the Apps Platform Request.

🥇 🙇 💯

[ovitrif]

To follow up on the merge could you also:

✅ Done! see #16819 (comment) 💯 🎉 🚀

@ParaskP7 Many thanks for making this possible ❤️