Update Detekt Configuration/Version

[ParaskP7]

This is the parent issue for the Update Detekt Configuration/Version project.

Platform Request: pdnsEh-qb-p2
Project Thread: N/A
Relates To:

• Detekt Integration - Phase.1 #13996
• Detekt Integration - Phase.2 #14011
• Detekt Integration - Phase.3 #14012
• Remove ktlint & update detekt to 1.19.0 #16819 (see review comment and the discussion surrounding that)

The Update Detekt Version project will first focus on changing Detekt's detekt.yml configuration so that it is being build upon the default config (buildUponDefaultConfig = true, just like it is already done on WCAndroid) and then the current 1.15.0 version will be updated to the latest stable (currently the 1.20.0).

Tasks

• Update Detekt Configuration - Build Upon Default Config #16893 @ParaskP7 [Update Detekt Configuration] Build Upon Default Config & Enable All Modules #16922
• Update Detekt Version - Update to 1.16.0 #16894 @ParaskP7 [Update Detekt Version] Update Detekt to 1.16.0 #16927
• Update Detekt Version - Update to 1.17.1 #16895 @ParaskP7 [Update Detekt Version] Update Detekt to 1.17.1 #16928
• Update Detekt Version - Update to 1.18.1 #16896 @ParaskP7 ✅ (This update will become part of the 1.19.0 update below as there were no changes this time)
• Update Detekt Version - Update to 1.19.0 #16897 @ParaskP7 [Update Detekt Version] Update Detekt to 1.19.0 #16949
• Update Detekt Version - Update to 1.20.0 #16898 @ParaskP7 ✅ (This update will become part of the 1.21.0 update below as there were few changes this time)
• Update Detekt Version - Update to the Latest Stable (1.21.0) #16899 @ParaskP7 [Update Detekt Version] Update Detekt to 1.21.0 #16961

---

In addition to the above main goals, we might also consider:

1. Enabling Detekt for all modules (currently Detekt is only running for the WordPress main module and none of the libs modules).
2. Resolving/Suppressing all Detekt baseline.xml related warnings (currently about 508).
3. Start using detektMain/Test task in favor of detekt as it is nowadays the recommend way to configure Detekt (see Using Type Resolution and more specifically here and here). The plain detekt is not running with type resolution enabled, while the detektMain/Test task does (for more info watch this nice Detekt related talk here, go to 30:30, up until 34:00).

Stretch Goals:

• Enable Detekt - Enable for All Modules @ParaskP7 [Update Detekt Configuration] Build Upon Default Config & Enable All Modules #16922
• Detekt Rules - Fine-Tune Default Rules (based on Detekt Integration - Phase.2 #14011) @ParaskP7 [Update Detekt Configuration] Fine-Tune Default Rules #16984
• Detekt - Resolve/Suppress All Baseline Warnings #17010
• Detekt - Enable Type Resolution (detektMain/Test) #17011

[peril-wordpress-mobile]

	Fails
🚫	Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

[ParaskP7]

I am now closing this parent issue as the primary goal has been achieved already, and, I am also moving these 2 below stretch goals tasks for later by creating separate issues for each, but still connecting them to this parent issue:

• Detekt - Resolve/Suppress All Baseline Warnings #17010
• Detekt - Enable Type Resolution (detektMain/Test) #17011