Issue/14004 menu item order #14183
Issue/14004 menu item order #14183
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
👋 @zwarm !
I have reviewed and tested this PR as per the instructions, everything works as expected, great work here! 🌟 🌟
I have left minor (🔍) comments, suggestions (💡) and some minor warnings (
Tip (ℹ️): Whenever you improve with Detekt, fixing an issue or suppress one, make sure to run the ./gradlew WordPress:detektBaseline command and see if that removes or updates an issue in the baseline. For example, your work on the LongMethod:ReaderPostMoreButtonUiStateBuilder.buildMoreMenuItemsBlocking(...) function, actually cleaned up the baseline by that one line! ❤️
<ID>LongMethod:ReaderPostMoreButtonUiStateBuilder.kt$ReaderPostMoreButtonUiStateBuilder$fun buildMoreMenuItemsBlocking( post: ReaderPost, onButtonClicked: (Long, Long, ReaderPostCardActionType) -> Unit ): MutableList<SecondaryAction></ID>
WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderMenuAdapter.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderMenuAdapter.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderMenuAdapter.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderMenuAdapter.java
Show resolved
Hide resolved
...src/main/java/org/wordpress/android/ui/reader/discover/ReaderPostMoreButtonUiStateBuilder.kt
Show resolved
Hide resolved
...src/main/java/org/wordpress/android/ui/reader/discover/ReaderPostMoreButtonUiStateBuilder.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/res/layout/reader_popup_menu_spacer_item.xml
Outdated
Show resolved
Hide resolved
|
@ParaskP7 - I incorporated all your suggestions. Thanks! |
Fixes #14004
This PR changes the More menu on the ReaderPost card
To test:
Scenario One
-- The item order has changed
-- There is a space before the block this site and/or report this site
Scenario Two
Launch the app
Navigate to following
Tap the more menu on a card.
Note that following:
-- The item order has changed
-- There is a space before the block this site and/or report this site
PR submission checklist:
I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.