Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: UI 💬 #468

Closed
13 tasks done
anbraten opened this issue Oct 24, 2021 · 57 comments · Fixed by #560
Closed
13 tasks done

Feedback: UI 💬 #468

anbraten opened this issue Oct 24, 2021 · 57 comments · Fixed by #560
Labels
summary it's a summary for lot of issues ui frontend related ux user experience

Comments

@anbraten
Copy link
Member

anbraten commented Oct 24, 2021

Summary of UI issues and smaller changes (based on new UI from #245) which can be posted as comments. For complex improvements please open a separate issue.

UI improvements

UI bugs

Next Round: #1314

@anbraten anbraten added the summary it's a summary for lot of issues label Oct 24, 2021
@anbraten anbraten pinned this issue Oct 24, 2021
@anbraten anbraten added the ui frontend related label Oct 24, 2021
@HerHde

This comment has been minimized.

@HerHde

This comment has been minimized.

@HerHde

This comment has been minimized.

@HerHde

This comment has been minimized.

@HerHde

This comment has been minimized.

@anbraten

This comment has been minimized.

@HerHde

This comment has been minimized.

@HerHde

This comment has been minimized.

@anbraten anbraten changed the title UI Feedback / Improvements Feedback: UI 💬 Nov 1, 2021
@6543

This comment has been minimized.

@HerHde

This comment has been minimized.

@HerHde

This comment has been minimized.

@HerHde

This comment has been minimized.

@HerHde

This comment has been minimized.

@catdevnull

This comment has been minimized.

@anbraten

This comment has been minimized.

@catdevnull

This comment has been minimized.

@HerHde

This comment has been minimized.

@6543 6543 mentioned this issue Dec 1, 2021
@6543 6543 closed this as completed in #560 Dec 3, 2021
@anbraten anbraten reopened this Dec 3, 2021
@6543

This comment has been minimized.

@6543

This comment has been minimized.

@6543
Copy link
Member

6543 commented Dec 11, 2021

#593 (comment)

  • add a label/tag disabled on /repos view for disabled repos

@6543
Copy link
Member

6543 commented Dec 11, 2021

#593 (comment)

  • on disabled repos -> repo config -> repo actions: deactivate button should be hidden
  • on disabled repos -> repo config -> repo actions: add activate button

@6543

This comment was marked as duplicate.

@anbraten

This comment has been minimized.

@ivictbor
Copy link

I believe WCAG compatibility is pretty important, at least AA grade. A lot of proffesianal interfaces developers (web/mobile) might use this CI, it is great! But a lot of us know WCAG requirments wery well (current issues in Woodpecker are notacible by human eye), so when we see Woodpecker's "gray on gray" (see this issue #721 ) it is kinda looks like, you know, ummm, a little bit "rookie designer mistake". This is absolutely OK, we all passed these steps, just sharing info how to improve and look more professional.
BTW drone satisfied this requirement (you might notice contrast white on blue an so on), you selected very cool color scheme too, only left to fix contrast of texts a little bit.

@qwerty287
Copy link
Contributor

Since my comment has been hidden while my idea isn't fixed, I'll just comment again:
I think it would be nice to see public projects of other users on their "profile" list.

@anbraten

This comment was marked as duplicate.

@anbraten

This comment was marked as resolved.

@6543 6543 added the ux user experience label May 17, 2022
@silverwind
Copy link
Contributor

silverwind commented Aug 5, 2022

I'd like to see this "Avenir" custom font removed and instead a standard system font stack to be used. Benefits are a consistent experience across multiple apps that also use system font stack, as well as faster load times and no flash of wrong fonts. See here for an example.

@tecosaur
Copy link

tecosaur commented Aug 6, 2022

This seems like the place to plop UI feedback? I've just started using Woodpecker and I'm sorry to say that the dark mode contrast is atrocious.

image

Let alone WCAG AAA, this fails WCAG AA standards of accessibility.

image
image

I recommend https://accessible-colors.com/ for checking that there's sufficient contrast between foreground and background colours.

Here's what #CCCFD4 looks like:

image

Copying Gitea's default foreground #bbc0ca is probably another decent option (it's 2/3 of the way to AAA from AA).

On a more stylistic note, I don't think the dark borders do the design any favours either. Here's a lighter version:

image

There are other improvements that can be made, but this would be a good starting point I think 🙂.

@tecosaur
Copy link

tecosaur commented Aug 6, 2022

Actually, on this topic, how would the project feel about taking heavy inspiration from Gitea's default theme?

@anbraten

This comment was marked as outdated.

@tecosaur

This comment was marked as outdated.

@ivictbor

This comment was marked as outdated.

@tecosaur
Copy link

tecosaur commented Aug 6, 2022

Thanks for that link, I wasn't aware of that! Good to see that it's been improved, though I do think it's only partway there.

For example, here's what I'm currently seeing:

image

If I just copy some styling from Gitea's default theme:

image

I find the latter markedly easier to read.

@ivictbor
Copy link

ivictbor commented Aug 6, 2022

Thanks for that link, I wasn't aware of that! Good to see that it's been improved, though I do think it's only partway there.

For example, here's what I'm currently seeing:

image

If I just copy some styling from Gitea's default theme:

image

I find the latter markedly easier to read.

Agree about minimalizm of colors in rows
Also clickable elements should have a separate color (like green repo link), otherwise user would not even know that they are clickable

@tecosaur
Copy link

tecosaur commented Aug 6, 2022

Woodpecker is already roughly similar to Gitea in design (e.g. the background colour is an exact match). For ease of use and accessibility having a clear design is important, and simply put it's much easier to use an existing project as a reference than coming up with something good from scratch.

I know I've only just started looking at this project, but perhaps a good avenue for initially improving the design/styling would be to take heavy inspiration from Gitea's default theme? In the slightly longer term, it would also be neat for Woodpecker to accept custom themes as Gitea does. That would make it easier to gradually develop a distinct visual identity (should the project want that) in parallel to a well-tested style and then switch it as the default once it's reached a sufficient level of refinement.

@qwerty287
Copy link
Contributor

I don't think we (the maintainers) have any disadvantages with custom themes (at least I don't have any...), so feel free to open an issue :)

@tecosaur
Copy link

tecosaur commented Aug 6, 2022

Cool, I'll see about doing so then. One quick question, if I want to try playing around with the styling myself is there some main CSS file like https://github.com/go-gitea/gitea/blob/main/web_src/less/themes/theme-arc-green.less that I could try tweaking?

@qwerty287
Copy link
Contributor

Not really. We're using https://windicss.org as CSS framework, and there's https://github.com/woodpecker-ci/woodpecker/blob/master/web/src/style.css, but I'd recommend you looking at WindiCSS.

This was referenced Aug 6, 2022
@6543

This comment was marked as duplicate.

@6543
Copy link
Member

6543 commented Sep 1, 2022

Pipelines in branches tab (for example master) also include Pull-requests against master => should not contain PRs

I would say they should, you can target PRs to different branches

@dvjn

This comment was marked as off-topic.

@qwerty287

This comment was marked as off-topic.

@6543 6543 mentioned this issue Oct 21, 2022
6 tasks
@6543
Copy link
Member

6543 commented Oct 21, 2022

Next Round: #1314

open comments will be copied ...

@6543 6543 closed this as completed Oct 21, 2022
@6543 6543 unpinned this issue Oct 21, 2022
@woodpecker-ci woodpecker-ci locked as resolved and limited conversation to collaborators Oct 21, 2022
@6543
Copy link
Member

6543 commented Oct 21, 2022

for contrast related stuff ( accessibility ) here is now: #1315

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
summary it's a summary for lot of issues ui frontend related ux user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.