Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea-inspired theme #1080

Closed
3 tasks done
tecosaur opened this issue Aug 6, 2022 · 5 comments
Closed
3 tasks done

Gitea-inspired theme #1080

tecosaur opened this issue Aug 6, 2022 · 5 comments
Labels
enhancement improve existing features ui frontend related

Comments

@tecosaur
Copy link

tecosaur commented Aug 6, 2022

Clear and concise description of the problem

The current woodpecker theme shares attributes with Gitea's arc-dark theme (e.g. the background colour is identical), but lacks much of the polish and consistency.

Having a well-constructed visual style is important for both ease of use and accessibility.attribute

Suggested solution

I propose taking heavy inspiration from Gitea's arc-dark theme, as it has already gone through this process and provides an efficient avenue to quickly improve the theme.

Alternative

No response

Additional context

As a quick example, I spent a few minutes tweaking the CSS on https://ci.woodpecker-ci.org/woodpecker-ci/woodpecker using Gitea's arc dark as a reference.

Here's the current style:

image

Using arc-dark as a reference point:

image

I find the latter version easier to look at, particularly:

  • seeing what is currently selected (of Activity/Branches)
  • realising that "woodpecker-ci" can be clicked
  • picking out the commit text

I think this serves as a decent example of the sort of change I'm thinking of.

This issue was spun off from #468 (comment) / #468 (comment).

Validations

@silverwind
Copy link
Contributor

Generally, I'd say gitea's arc-green should probably not be copied as-is, as I consider it too bright for a dark theme. Also, green primary color is a bit of an odd choice in general, blue seems more popular in general.

Maybe we'll darken arc-green a bit in gitea, or maybe we make a new dark theme, it's not really decided yet.

@anbraten
Copy link
Member

I think we should take Giteas theme and all other tools we use (I like some design aspects of Ghub, Glab ... pretty much as well) as inspiration and "copy" nice parts. But in general I would suggest to stick to our current design and try to further improve it instead of rebuilding it on Giteas layout. It already became pretty nice IMO when you compare it to the first draft.

@6543 6543 added enhancement improve existing features and removed pending:feature labels Sep 3, 2022
@6543
Copy link
Member

6543 commented Sep 3, 2022

I would say #1079 does cover it?

@6543
Copy link
Member

6543 commented Sep 3, 2022

but also we should improve our default themes where possible ;)

@6543 6543 added the ui frontend related label Oct 21, 2022
@mvdkleijn
Copy link
Contributor

The current dark theme in "next" is a little too dark and bland for my taste. The lack of highlighting for example. As for the green that @silverwind mentioned... that just makes sense because that's the Woodpecker color of choice.

I would say that #1079 does cover it (apart from maybe a themes index?). Having good, usable default themes is important, however, it would be nice to have #1079 so we can have themes matching Gitea or Forgejo.

Perhaps this issue should be closed in favor of #1079 ? (to keep issues clean-ish)

@anbraten anbraten closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features ui frontend related
Projects
None yet
Development

No branches or pull requests

5 participants