Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme problem #721

Closed
wxiaoguang opened this issue Jan 27, 2022 · 4 comments
Closed

Dark theme problem #721

wxiaoguang opened this issue Jan 27, 2022 · 4 comments
Labels
bug Something isn't working ui frontend related
Milestone

Comments

@wxiaoguang
Copy link

Woodpecker: {"source": "https://github.com/woodpecker-ci/woodpecker","version": "next-9feb6be9"}

Screenshot:

image

There might be 2 problems here:

  1. The bottom UI is always using dark theme.
  2. The texts are hard to read
@6543 6543 added bug Something isn't working ui frontend related labels Jan 27, 2022
@ivictbor
Copy link

ivictbor commented Feb 3, 2022

Also some other colors contrast in the design are not WCAG - compatible, e.g.

image

Even large text on AA grade fails which is generally means a lot of issues with reading text on different monitors:

image

Just in case if you have design in Figma, it is prossible easily check WCAG criteria with this plugin https://www.figma.com/community/plugin/748533339900865323/Contrast , though currenlty it is easy to find such colors by human eye

@ivictbor ivictbor mentioned this issue Mar 22, 2022
13 tasks
@anbraten
Copy link
Member

We currently do not have a Figma design, but I would absolutely love to have one. It would be very helpful IMO for developers to follow Figma and it would help designers without Vue, code knowledge to improve / suggest UI changes. I have used Figma a bit in the past, but I am really not an expert, so maybe someone else cloud help creating some components and some main views in there. For the colors we use the list of windicss colors from: https://windicss.org/utilities/general/colors.html

Problems related contrast and some design issues in general are somehow known, but I am not an expert on this, so help is absolutely appreciated.

@6543 6543 added this to the 1.0.0 milestone Apr 25, 2022
@6543
Copy link
Member

6543 commented Jun 16, 2022

should be improved now :)

@6543
Copy link
Member

6543 commented Jun 17, 2022

#985

@6543 6543 closed this as completed Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui frontend related
Projects
None yet
Development

No branches or pull requests

4 participants