Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate with Google without the Google SDK in non-production builds #9675

Merged
merged 2 commits into from
May 15, 2023

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented May 9, 2023

Description

In the latest WordPress and Jetpack release (22.2), we have been using our own implementation of the flow to authenticate with the WordPress.com backend using a Google account. It's working well so it's time to roll it out to other apps.

However, I don't feel comfortable adopting it full turkey without a remote feature flag to disable it if we discover issues. @pmusolino mentioned there'll soon be support for remote feature flags, so in the meantime I'd like to break the ground and introduce:

  • A build-time feature flags
  • The logic to read it when configuring the authenticator layer

I expect that, once the remote feature flags will be available, we'll be able to migrate most of this set to the new system.

In the meantime, the few people on internal builds using Google accounts will run through the new flow.

Testing instructions

Run the app on the Simulator, add a breakpoint into GoogleAuthenticator.swift at line 134 (Shift Cmd O to open the jump bar to fuzzy find the file since it's buried in the Pods, then Cmd L 134 to jump to that line) where the switch between flows occur and verify the SDK-less flow runs.

image
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 9, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr9675-54d01ac on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio force-pushed the mokagio/sdk-less-google branch from d714dbf to 54d01ac Compare May 11, 2023 06:51
@mokagio mokagio changed the title Authenticate with Google without the Google SDK Authenticate with Google without the Google SDK in non-production builds May 11, 2023
@mokagio mokagio added the feature: login Related to any part of the log in or sign in flow, or authentication. label May 11, 2023
@mokagio mokagio added this to the 13.7 milestone May 11, 2023
@mokagio mokagio marked this pull request as ready for review May 11, 2023 09:42
@itsmeichigo itsmeichigo self-assigned this May 15, 2023
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mokagio mokagio merged commit 5ee53c9 into trunk May 15, 2023
@mokagio mokagio deleted the mokagio/sdk-less-google branch May 15, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants