Authenticate with Google without the Google SDK in non-production builds #9675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the latest WordPress and Jetpack release (22.2), we have been using our own implementation of the flow to authenticate with the WordPress.com backend using a Google account. It's working well so it's time to roll it out to other apps.
However, I don't feel comfortable adopting it full turkey without a remote feature flag to disable it if we discover issues. @pmusolino mentioned there'll soon be support for remote feature flags, so in the meantime I'd like to break the ground and introduce:
I expect that, once the remote feature flags will be available, we'll be able to migrate most of this set to the new system.
In the meantime, the few people on internal builds using Google accounts will run through the new flow.
Testing instructions
Run the app on the Simulator, add a breakpoint into
GoogleAuthenticator.swift
at line 134 (Shift Cmd O
to open the jump bar to fuzzy find the file since it's buried in the Pods, thenCmd L 134
to jump to that line) where the switch between flows occur and verify the SDK-less flow runs.RELEASE-NOTES.txt
if necessary.