Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate with Google without the Google SDK in non-production builds #9675

Merged
merged 2 commits into from
May 15, 2023
Merged

Authenticate with Google without the Google SDK in non-production builds #9675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a59889a
Define feature flag for Google SDK-less authentication
mokagio May 9, 2023
54d01ac
Pass feature flag value for Google SDK-less auth to WPAuthenticator
mokagio May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Experiments/Experiments/DefaultFeatureFlagService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
return buildConfig == .localDeveloper || buildConfig == .alpha
case .euShippingNotification:
return buildConfig == .localDeveloper || buildConfig == .alpha
case .sdkLessGoogleSignIn:
return buildConfig == .localDeveloper || buildConfig == .alpha
default:
return true
}
Expand Down
4 changes: 4 additions & 0 deletions Experiments/Experiments/FeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,4 +207,8 @@ public enum FeatureFlag: Int {
/// Enables EU Bound notifications inside the Shipping Labels feature
///
case euShippingNotification

/// Do not use the Google SDK when authenticating through a Google account.
///
case sdkLessGoogleSignIn
}
3 changes: 2 additions & 1 deletion WooCommerce/Classes/Extensions/WordPressAuthenticator+Woo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ extension WordPressAuthenticator {
enableManualSiteCredentialLogin: true,
enableManualErrorHandlingForSiteCredentialLogin: isManualErrorHandlingEnabled,
useEnterEmailAddressAsStepValueForGetStartedVC: true,
enableSiteAddressLoginOnlyInPrologue: true)
enableSiteAddressLoginOnlyInPrologue: true,
googleLoginWithoutSDK: featureFlagService.isFeatureFlagEnabled(.sdkLessGoogleSignIn))

let systemGray3LightModeColor = UIColor(red: 199/255.0, green: 199/255.0, blue: 204/255.0, alpha: 1)
let systemLabelLightModeColor = UIColor(red: 0, green: 0, blue: 0, alpha: 1)
Expand Down