Skip to content

Commit

Permalink
Authenticate with Google without the SDK in non-prod builds (#9675)
Browse files Browse the repository at this point in the history
  • Loading branch information
mokagio authored May 15, 2023
2 parents 36d7169 + 54d01ac commit 5ee53c9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions Experiments/Experiments/DefaultFeatureFlagService.swift
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
return buildConfig == .localDeveloper || buildConfig == .alpha
case .euShippingNotification:
return buildConfig == .localDeveloper || buildConfig == .alpha
case .sdkLessGoogleSignIn:
return buildConfig == .localDeveloper || buildConfig == .alpha
default:
return true
}
Expand Down
4 changes: 4 additions & 0 deletions Experiments/Experiments/FeatureFlag.swift
Original file line number Diff line number Diff line change
Expand Up @@ -203,4 +203,8 @@ public enum FeatureFlag: Int {
/// Enables EU Bound notifications inside the Shipping Labels feature
///
case euShippingNotification

/// Do not use the Google SDK when authenticating through a Google account.
///
case sdkLessGoogleSignIn
}
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ extension WordPressAuthenticator {
enableManualSiteCredentialLogin: true,
enableManualErrorHandlingForSiteCredentialLogin: isManualErrorHandlingEnabled,
useEnterEmailAddressAsStepValueForGetStartedVC: true,
enableSiteAddressLoginOnlyInPrologue: true)
enableSiteAddressLoginOnlyInPrologue: true,
googleLoginWithoutSDK: featureFlagService.isFeatureFlagEnabled(.sdkLessGoogleSignIn))

let systemGray3LightModeColor = UIColor(red: 199/255.0, green: 199/255.0, blue: 204/255.0, alpha: 1)
let systemLabelLightModeColor = UIColor(red: 0, green: 0, blue: 0, alpha: 1)
Expand Down

0 comments on commit 5ee53c9

Please sign in to comment.