This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix border styles not visible in the editor in Featured Product and Featured Category blocks #8838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eatured Category blocks in core
Aljullu
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
albarin
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -86 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
tarunvijwani
changed the title
Aljullu
added
the
release: cherry-pick
Aljullu
added a commit
that referenced
this pull request
Mar 28, 2023
…eatured Category blocks in core (#8838)
Aljullu
added a commit
that referenced
this pull request
Mar 28, 2023
…eatured Category blocks in core (#8838)
Aljullu
added a commit
that referenced
this pull request
Mar 28, 2023
* Empty commit for release pull request * Update version numbers to 9.8.3 * Add 9.8.3 changelog * Fix save changes bug in Firefox browser (#8754) * Fix border styles not visible in the editor in Featured Product and Featured Category blocks in core (#8838) * Check for address on shippingData (#8878) * Add 9.8.3 testing steps --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Saad Tarhi <[email protected]> Co-authored-by: Thomas Roberts <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in WC core that made the border not visible in the editor for the Featured Product and Featured Category blocks. That happened because in #8472 we refactored the code to use
useBorderProps(), but that function has an extra protection so it returns no styles in WC core.I removed that extra protection from
useBorderProps()anduseColorProps(). IMO, if we want some styling options not to be available in core, we need to gate them in the block metadata, but adding those protections into theuseXProps()hook is dangeours because we end up with cases like this, where the controls are visible but they take no effect.Testing
User Facing Testing
WOOCOMMERCE_BLOCKS_PHASE=1 npm run build, so you simulate a WC core build.Unlinkbutton on the border controls and try setting different values for color and width for each of the border sides (top,right,bottom,left).Featured CategoryandFeatured Productblocks.WooCommerce Visibility
Changelog