This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add parsed border props to featured items #8472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
focus: blocks
Specific work involving or impacting how blocks behave.
block: featured category
Issues related to the Featured Category block,
block: featured product
Issues related to the Featured Product block.
labels
Feb 17, 2023
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
February 17, 2023 16:51
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: +389 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works perfectly, thanks @roykho!
In the WooCommerce Visibility
section, you should mark WooCommerce Core
, as this feature is available in core. Also, I would add a type: bug
label. Besides that, every LGTM. 👌
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: featured category
Issues related to the Featured Category block,
block: featured product
Issues related to the Featured Product block.
focus: blocks
Specific work involving or impacting how blocks behave.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8383
This PR adds in the border props so that featured blocks knows how to parse the border styles in the editor.
Testing
User Facing Testing
Unlink
button on the border controls and try setting different values for color and width for each of the border sides (top,right,bottom,left).Featured Category
andFeatured Product
blocks.WooCommerce Visibility
Performance Impact
Changelog