This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix "Save changes" default behavior bug in the Firefox browser #8754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +12 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Works great in all browsers now. Thank you for the fixing it so quickly, @tarhi-saad! 🎉
tarhi-saad
deleted the
fix/local-pickup-save-changes-firefox-browser-bug
branch
Aljullu
added
the
release: cherry-pick
Aljullu
pushed a commit
that referenced
this pull request
Mar 28, 2023
Aljullu
pushed a commit
that referenced
this pull request
Mar 28, 2023
Aljullu
added a commit
that referenced
this pull request
Mar 28, 2023
* Empty commit for release pull request * Update version numbers to 9.8.3 * Add 9.8.3 changelog * Fix save changes bug in Firefox browser (#8754) * Fix border styles not visible in the editor in Featured Product and Featured Category blocks in core (#8838) * Check for address on shippingData (#8878) * Add 9.8.3 testing steps --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Saad Tarhi <[email protected]> Co-authored-by: Thomas Roberts <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Local Pickup admin page, clicking on the
Save changeswill redirect to a blank (i.e.,/wp-admin/admin.php?local_pickup_title=Local+Pickup). The changes may not be saved in some cases!Fixes #8717
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
You should use the Firefox browser for this test.
WooCommerce/Shipping/Local pickupSave changesbutton. Ensure you are not redirected to another page, and the noticeLocal Pickup settings have been saved.is displayedSave changesbutton. Ensure you have the same results in step 2WooCommerce Visibility
Performance Impact
Changelog