-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
05bb700
to
c4744db
Compare
This should be moved inline for the settings page only.This should be moved inline for the settings page only.
woocommerce-blocks/src/Shipping/ShippingController.php Lines 43 to 54 in c4744db
🚀 This comment was generated by the automations bot based on a
|
This should be improved to include error handling in case...This should be improved to include error handling in case of API failure, or invalid data being sent that does not match the schema. This would fail silently on the API side.
woocommerce-blocks/assets/js/extensions/shipping-methods/pickup-location/settings-context.tsx Lines 130 to 142 in c4744db
🚀 This comment was generated by the automations bot based on a
|
TypeScript Errors ReportFiles with errors: 444
assets/js/base/components/cart-checkout/shipping-rates-control-package/package-rates.tsx
assets/js/base/components/cart-checkout/shipping-rates-control/types.ts assets/js/base/components/cart-checkout/totals/shipping/shipping-address.tsx assets/js/blocks/checkout/inner-blocks/checkout-pickup-options-block/index.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/block.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/edit.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/index.tsx assets/js/extensions/payment-methods/cod/index.js assets/js/extensions/shipping-methods/pickup-location/edit-location/form.tsx assets/js/extensions/shipping-methods/pickup-location/edit-location/state-control.tsx assets/js/extensions/shipping-methods/pickup-location/save.tsx assets/js/extensions/shipping-methods/pickup-location/settings-context.tsx assets/js/extensions/shipping-methods/shared-components/sortable-table/index.tsx packages/checkout/components/store-notice/index.tsx |
The release ZIP for this PR is accessible via:
|
Size Change: +58.6 kB (+6%) 🔍 Total Size: 1.08 MB
ℹ️ View Unchanged
|
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
The release ZIP for this PR is accessible via:
|
a3386b2
to
1e6ff36
Compare
56829db
to
b03435a
Compare
1560ac7
to
fe155bf
Compare
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/base/components/cart-checkout/shipping-rates-control-package/package-rates.tsx
assets/js/base/components/cart-checkout/shipping-rates-control/types.ts assets/js/base/components/cart-checkout/totals/shipping/shipping-address.tsx assets/js/base/components/radio-control/option-layout.tsx assets/js/blocks/checkout/inner-blocks/checkout-pickup-options-block/index.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/block.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/edit.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/index.tsx assets/js/extensions/payment-methods/cod/index.js assets/js/extensions/shipping-methods/pickup-location/edit-location/form.tsx assets/js/extensions/shipping-methods/pickup-location/edit-location/state-control.tsx assets/js/extensions/shipping-methods/pickup-location/general-settings.tsx assets/js/extensions/shipping-methods/pickup-location/save.tsx assets/js/extensions/shipping-methods/pickup-location/settings-context.tsx assets/js/extensions/shipping-methods/shared-components/settings-card/index.tsx assets/js/extensions/shipping-methods/shared-components/settings-modal/index.tsx assets/js/extensions/shipping-methods/shared-components/settings-section/index.tsx assets/js/extensions/shipping-methods/shared-components/sortable-table/index.tsx packages/checkout/components/store-notice/index.tsx |
* add form validation for admin screen * add types * add validation to fields * restore form ref
a5ce9ef
to
da6951b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick glance, LGTM,
@mikejolley @senadir Look like this PR introduces a PHP warning in the block editor |
This is the feature branch that contains the Local Pickup work, code has existed in PRs and those were all merged into this one.
Local Pickup refers to the work to:
pickup_location
, which is different fromlocal_pickup
in a sense that it doesn't rely on shipping zones.closes #7136
closes #7161
closes #7163
closes #7164
Screenshots
User Facing Testing
WooCommerce Visibility
Changelog