This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add validation to local pickup fields #8007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: bug
senadir
commented
Dec 21, 2022
Comment on lines
+72
to
+77
| const form = | ||
| formRef?.current as unknown as HTMLFormElement; | ||
| if ( form.reportValidity() ) { | ||
| onSave( values ); | ||
| onClose(); | ||
| } |
There was a problem hiding this comment.
Button here is outside the form, so we use the ref instead of event.target.form
Comment on lines
+29
to
+37
| onClick={ ( | ||
| event: React.MouseEvent< HTMLButtonElement, MouseEvent > | ||
| ) => { | ||
| const target = event.target as HTMLButtonElement; | ||
| if ( target?.form?.reportValidity() ) { | ||
| save(); | ||
| } | ||
| } } | ||
| type="submit" |
There was a problem hiding this comment.
This is all that's needed to show errors, reportValidity will return true once all fields are valid.
|
The release ZIP for this PR is accessible via: |
TypeScript Errors ReportFiles with errors: 444
assets/js/base/components/cart-checkout/shipping-rates-control-package/package-rates.tsx
assets/js/base/components/cart-checkout/shipping-rates-control/types.ts assets/js/base/components/cart-checkout/totals/shipping/shipping-address.tsx assets/js/base/components/reviews/review-list-item/index.js assets/js/base/components/reviews/review-list/index.js assets/js/base/components/reviews/review-sort-select/index.js assets/js/base/context/hooks/cart/use-store-cart-coupons.ts assets/js/base/context/hooks/use-checkout-notices.js assets/js/base/context/providers/cart-checkout/checkout-processor.js assets/js/base/context/providers/store-snackbar-notices/components/snackbar-notices-container.js assets/js/base/utils/errors.js assets/js/blocks/cart-checkout-shared/payment-methods/payment-method-error-boundary.js assets/js/blocks/cart/block.js assets/js/blocks/checkout/block.tsx assets/js/blocks/checkout/inner-blocks/checkout-pickup-options-block/index.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/block.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/edit.tsx assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/index.tsx assets/js/data/cart/controls.js assets/js/data/cart/test/resolvers.js assets/js/extensions/payment-methods/cod/index.js assets/js/extensions/shipping-methods/pickup-location/edit-location/form.tsx assets/js/extensions/shipping-methods/pickup-location/edit-location/state-control.tsx assets/js/extensions/shipping-methods/pickup-location/save.tsx assets/js/extensions/shipping-methods/pickup-location/settings-context.tsx assets/js/extensions/shipping-methods/shared-components/sortable-table/index.tsx packages/checkout/components/store-notice/index.tsx packages/checkout/components/store-notices-container/index.tsx |
|
Size Change: +127 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
mikejolley
approved these changes
Dec 21, 2022
senadir
added a commit
that referenced
this pull request
Jan 12, 2023
* add form validation for admin screen * add types * add validation to fields * restore form ref
senadir
added a commit
that referenced
this pull request
Jan 12, 2023
* add form validation for admin screen * add types * add validation to fields * restore form ref
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds simple validation to form fields to prevent empty values from being persisted. It adds it to the modal, the general form, and the editor.
Fixes #7988
Fixes #7989
Fixes #7991
Screenshots
Testing