Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Cart Block > column display not working anymore #8581

Closed
Marc-pi opened this issue Feb 28, 2023 · 4 comments
Closed

Cart Block > column display not working anymore #8581

Marc-pi opened this issue Feb 28, 2023 · 4 comments
Labels
block: cart Issues related to the cart block. block-type: local pickup Issues related to local pickup. type: bug The issue/PR concerns a confirmed bug.

Comments

@Marc-pi
Copy link

Marc-pi commented Feb 28, 2023

Describe the bug

Willing to test the new Local Pickup feature (especially how it is displayed in cart page), i stumble opon a strange change, that seems to be a nice regression ;-)

  • Adding a new instance of the Cart Block generates the cart in a single column on front (even if the columns blocks are used by the cart block).
  • There is no way to display it in 2 columns on front like it was before
  • Confirmed on several websites.

To reproduce

Steps to reproduce the behavior:

On 2 websites that did run already WooCommerce

  1. Create a new page
  2. Add the Cart Block within
  3. Compare the new layout with the current Cart page (i did have a cart page already)

NB i am not able to see the new display with steps for Local Pickup. When submiting the Local Pickup setting Page, i get a blank page. I'll open a new issue after this one if fixed / confirmed.
image

I did read the Local Pickup test protocol
https://github.com/woocommerce/woocommerce-blocks/blob/b49573b91d37cff511c3fb3288e0458dbf0c582f/docs/internal-developers/testing/cart-checkout/local-pickup.md

Expected behavior

Add back 2 columns on desktop ?!?
I did not read there was a change on this ?
I did not find any warning in #7433, nor after a search on other issues/PR.
Or did i miss something : local pickup feature changed the way the cart is displayed (desktop and mobile == same display ?)

Screenshots

  • Old Behavior

image

  • Actual display

image

WP Environment

WP 6.1.1
Woo 7.4.0
Woo Blocks 9.6.3
Theme TT2
No other plugins installed

@Marc-pi Marc-pi added the type: bug The issue/PR concerns a confirmed bug. label Feb 28, 2023
@Marc-pi
Copy link
Author

Marc-pi commented Mar 1, 2023

same findings on Woo 7.4.1

@Marc-pi
Copy link
Author

Marc-pi commented Mar 1, 2023

confirmed on Woo Blocks 9.7.0 as well

@imanish003 imanish003 added the block: cart Issues related to the cart block. label Mar 2, 2023
@nielslange nielslange added the block-type: local pickup Issues related to local pickup. label Mar 8, 2023
@ralucaStan
Copy link
Contributor

@Marc-pi thank you so much for trying out Local pickup.
I tried testing again with the latest version 9.8.0 and I was not able to replicate it.

  • I activated the blocks local pickup
  • I created a new page and added the Cart block
  • I checked both the editor and the front-end and things worked as expected.

Would you mind trying again and sharing the results. Thank you so much for your help.

@ralucaStan
Copy link
Contributor

Hey @Marc-pi
I am going to close this issue as there was no reply from your side and we couldn't replicate.

With #8894 we enforced a wide alignment for the C & C Blocks.

Also, there is the option to change the Align for blocks from none to wide
Screenshot 2023-04-10 at 14 53 35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block-type: local pickup Issues related to local pickup. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

4 participants