This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Lazy load missing translation files #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: bug
nielslange
requested review from
a team and
opr
and removed request for
a team
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
nielslange
changed the title
|
Given you're loading lazy loaded translation, this should also include Cart inner blocks. |
Thanks for pointing this out. Initially, I thought to spin up a separate PR for adding the cart translation files. But shipping them with this PR is a good suggestion, as the checkout and the cart block go hand in hand. I just adjusted the PR based on your feedback, @senadir. |
nielslange
force-pushed
the
fix/5005-lazy-load-missing-translation-files
branch
from
33840ce to
bcbcad8
Compare
opr
reviewed
Nov 19, 2021
There was a problem hiding this comment.
Hey @nielslange - this isn't working for me, I've followed the steps and in the editor everything is in Spanish, but the front-end of my cart/checkout, besides the input labels and shipping options, is still in English. Any ideas on what I might be missing? I've saved the page too.
Also, just a note on the testing notes here, I think you should remove the steps about checking out trunk and verifying the bug, leave only the steps to verify the fix.
I forgot to mention that you need to update the translations files via
Thanks for suggesting this. I've updated the description of this PR and will only point out how to test a fix in the future, and not how to reproduce the initial bug. |
Aljullu
added
the
status: blocker
opr
approved these changes
Nov 22, 2021
|
Re-tested and it worked 🙌🏼 |
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Lazo load missing translation files * Lazy load cart translation files
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Lazo load missing translation files * Lazy load cart translation files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5005 | Related #5106
Screenshots
Spanish: Terms and conditions
German: Shipping address description
Testing
WP Admin → Dashboard → Translations → Update Translations.Additional notes
Kindly note that I also added
"lint:php-fix": "composer run-script phpcbf ./src",topackage.jsonso that I could fix linting problems within PHP files.Changelog