Translation of "Proceed to Checkout" button isn't working

[nielslange]

Describe the bug

In #5112, we added missing lazy loaded translations files. In 4629379-zd-woothemes, a customer reported that the Norwegian translation of the "Proceed to Checkout" button isn't working.

I looked up this problem and found out that it’s caused by the following section:

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/b56790a52c41730de4fba25bb1640b6a0d7c46c0/src/BlockTypes/Cart.php#L205-L218

Instead of cart-blocks/checkout-button, we’re currently referring to cart-blocks/checkout-button-frontend.js. This leads to the fact that the translation of the "Proceed to Checkout" button does not get loaded.

To reproduce

1. Create a test page and add the cart block.
2. Go to /wp-admin/options-general.php and change the site language to Norsk bokmål.
3. Go to /wp-admin/update-core.php and update the translations.
4. Go to the frontend, add a product and look up the test page with the cart block.
5. See that the "Proceed to Checkout" button is not translated, even though a Norwegian translation exists.

Expected behavior

The translation of the "Proceed to Checkout" button should be visible.

Screenshots

Temporary fix

The following code snippet allows to temporarily fix this problem:

// Define our filter callback.
function myPluginGettextFilter( translation, text, domain ) {
	if ( text === 'Proceed to Checkout' ) {
		return 'Fortsett til kassen';
	}
	return translation;
}

// Adding the filter
wp.hooks.addFilter(
	'i18n.gettext',
	'my-plugin/override-fulfilled-all-orders-text',
	myPluginGettextFilter
);

This code snippet can be added to a WordPress site using the Simple Custom CSS and JS plugin: