This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Revert #10032 so All Products renders in the frontend #11263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
added
type: bug
woocommercebot
requested review from
a team and
samueljseay
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/products/all-products/save.js
|
|
Size Change: -30 B (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
roykho
approved these changes
Oct 16, 2023
roykho
pushed a commit
that referenced
this pull request
Oct 16, 2023
roykho
added a commit
that referenced
this pull request
Oct 17, 2023
* Empty commit for release pull request * Update to version 11.3.1 * Revert #10032 so All Products renders in the frontend (#11263) * Add testing instructions * Fix linting errors in testing instructions for 1130 * Update testing instructions --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: roykho <[email protected]> Co-authored-by: Karol Manijak <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #10032 so All Products block renders properly in the frontend.
Revert part of #11055.
What
Fixes #11261 and #11215
Why
The newly added All Products block doesn't render on the frontend.
This is due to #10032 in which the
data-attributesHTML attribute was removed from the block's save function which is a must for a correct block render.Additionally, this PR un-skips two tests that were skipped in the scope of #10032. These tests correctly found the problem of All Products block not being rendered.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog