Revert #10032 so All Products renders in the frontend (#11263)

woocommerce · Oct 16, 2023 · 97bf32f · 97bf32f
1 parent 7bd5080
commit 97bf32f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 33 deletions.
diff --git a/assets/js/blocks/products/all-products/deprecated.js b/assets/js/blocks/products/all-products/deprecated.js
@@ -33,32 +33,4 @@ const v1 = {
 	},
 };
 
-const v2 = {
-	attributes: Object.assign( {}, attributeDefinitions, {
-		rows: { type: 'number', default: 1 },
-	} ),
-	save( { attributes } ) {
-		const dataAttributes = {};
-		Object.keys( attributes )
-			.sort()
-			.forEach( ( key ) => {
-				dataAttributes[ key ] = attributes[ key ];
-			} );
-		const data = {
-			'data-attributes': JSON.stringify( dataAttributes ),
-		};
-		return (
-			<div
-				className={ getBlockClassName(
-					'wc-block-all-products',
-					attributes
-				) }
-				{ ...data }
-			>
-				<InnerBlocks.Content />
-			</div>
-		);
-	},
-};
-
-export default [ v2, v1 ];
+export default [ v1 ];
diff --git a/assets/js/blocks/products/all-products/save.js b/assets/js/blocks/products/all-products/save.js
@@ -9,12 +9,22 @@ import { InnerBlocks } from '@wordpress/block-editor';
 import { getBlockClassName } from '../utils.js';
 
 export default function save( { attributes } ) {
+	const dataAttributes = {};
+	Object.keys( attributes )
+		.sort()
+		.forEach( ( key ) => {
+			dataAttributes[ key ] = attributes[ key ];
+		} );
+	const data = {
+		'data-attributes': JSON.stringify( dataAttributes ),
+	};
 	return (
 		<div
 			className={ getBlockClassName(
 				'wc-block-all-products',
 				attributes
 			) }
+			{ ...data }
 		>
 			<InnerBlocks.Content />
 		</div>

diff --git a/tests/e2e/tests/price-filter/price-filter.block_theme.side_effects.spec.ts b/tests/e2e/tests/price-filter/price-filter.block_theme.side_effects.spec.ts
@@ -42,8 +42,7 @@ test.describe( `${ blockData.name } Block - with All products Block`, () => {
 		await page.goto( `/?p=${ postId }`, { waitUntil: 'commit' } );
 	} );
 
-	// eslint-disable-next-line playwright/no-skipped-test
-	test.skip( 'should show all products', async ( { frontendUtils } ) => {
+	test( 'should show all products', async ( { frontendUtils } ) => {
 		const allProductsBlock = await frontendUtils.getBlockByName(
 			'woocommerce/all-products'
 		);
@@ -60,8 +59,7 @@ test.describe( `${ blockData.name } Block - with All products Block`, () => {
 		expect( products ).toHaveLength( 9 );
 	} );
 
-	// eslint-disable-next-line playwright/no-skipped-test
-	test.skip( 'should show only products that match the filter', async ( {
+	test( 'should show only products that match the filter', async ( {
 		page,
 		frontendUtils,
 	} ) => {