Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Product Collection, Price Filter, and All Products Blocks playwright's E2E tests #11270

Closed
tarhi-saad opened this issue Oct 16, 2023 · 2 comments
Labels
type: cooldown Things that are queued for a cooldown period (assists with planning).

Comments

@tarhi-saad
Copy link
Contributor

Describe the bug

While trying to fix some E2E tests on #11055, other failing tests emerged. I recommended bypassing these tests and opening this ticket to address them separately. I looked into a quick solution but couldn't identify one. we skipped 3 Product tests:

  • 1 related to the Product Collection Block
  • 2 related to the Price Filter and All Products Blocks

To reproduce

1- Remove the skip keyword from the following tests:
https://github.com/woocommerce/woocommerce-blocks/blob/trunk/tests/e2e/tests/price-filter/price-filter.block_theme.side_effects.spec.ts#L46
https://github.com/woocommerce/woocommerce-blocks/blob/trunk/tests/e2e/tests/price-filter/price-filter.block_theme.side_effects.spec.ts#L64
https://github.com/woocommerce/woocommerce-blocks/blob/trunk/tests/e2e/tests/product-collection/compatibility-layer.block_theme.side_effects.spec.ts#L119

2- Run Playwright's E2E Tests. The tests should fail

Expected behavior

The tests should pass

@tarhi-saad tarhi-saad added type: cooldown Things that are queued for a cooldown period (assists with planning). category: tests labels Oct 16, 2023
@gigitux
Copy link
Contributor

gigitux commented Oct 16, 2023

The E2E tests about the compatibility layer are fixed by #11273.

@kmanijak
Copy link
Contributor

The E2E tests about Price Filter were re-enabled and fixed in #11263

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: cooldown Things that are queued for a cooldown period (assists with planning).
Projects
None yet
Development

No branches or pull requests

3 participants