This repository has been archived by the owner on Jan 26, 2019. It is now read-only.
✅ Upstream sync (Nov 5 2017) #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootstraponline
changed the title
bootstraponline
changed the title
bootstraponline
changed the title
|
@bootstraponline This would also affect other issues as well: May affect and help with: #186 as dependencies of Would fix: #173 Hope this helps! |
|
Many thanks! |
|
Released in 2.9.0, thanks again! |
|
Thank you!! create-react-app-typescript is awesome. |
|
@wmonk Is 2.9.0 released or not? I see 2.8.0 on https://www.npmjs.com/package/react-scripts-ts and in my |
|
@edzis 2.9.0 was released, but got unpublished due to several issues that have to be fixed upstream (i.e. in CRA) before it can be considered 'stable' again. Next merge is planned for the next CRA release. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased the TypeScript changes on upstream
create-react-app. Travis CI is passing. ✅It'd be great to have this merged to keep current with React changes.
Fixes #182
There are two commits:
Pull latest from facebookincubator/create-react-appRebase TypeScript changes