Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

2.9.0 #220

Merged
merged 5 commits into from
Jan 13, 2018
Merged

2.9.0 #220

merged 5 commits into from
Jan 13, 2018

Conversation

wmonk
Copy link
Owner

@wmonk wmonk commented Jan 11, 2018

@DorianGrey i've spent some time creating the future 2.9.0 branch as its very annoying that master is unable to be published. I've picked all PRs that were merged into master after #183 was merged. Can you just sanity check this includes the correct changes. After this is merged i will create 2.10.0 with the 1.0.17 changes from facebook.

wmonk and others added 4 commits January 11, 2018 08:31
Add support for fork-ts-checker-webpack-plugin
Adjust 'Testing components' section to use the correct TS versions.
 Add link to typescript User Guide
@wmonk wmonk requested a review from DorianGrey January 11, 2018 08:38
@wmonk
Copy link
Owner Author

wmonk commented Jan 11, 2018

@DorianGrey also the plan is to reset the master branch to this branch. The merged upsteam is at #221

Copy link
Collaborator

@DorianGrey DorianGrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Rebasing sounds reasonable to get rid of the publish/unpublish part.

@wmonk wmonk changed the base branch from 2.8.0 to master January 13, 2018 10:01
@wmonk wmonk merged commit 4786bec into master Jan 13, 2018
import ReactDOM from 'react-dom';
```ts
import * as React from 'react';
import * asReactDOM from 'react-dom';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space missing

@wmonk
Copy link
Owner Author

wmonk commented Jan 13, 2018

@stephtr that is just the commit, please see the pull request diff and you can see that the change only adds a single line, but doesn't change any other versions. If you check #221 this will be release to have parity with 1.0.17 of facebooks upstream.

@wmonk wmonk deleted the 2.9.0 branch January 14, 2018 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants