Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

babel & raf missing after eject. Deps out of date #182

Closed
bootstraponline opened this issue Nov 5, 2017 · 3 comments
Closed

babel & raf missing after eject. Deps out of date #182

bootstraponline opened this issue Nov 5, 2017 · 3 comments

Comments

@bootstraponline
Copy link

bootstraponline commented Nov 5, 2017

In comparing the typescript create-react-app ejected package.json to upstream, I noticed some differences.

  • Is babel suppose to be missing?
  • Is raf removed intentionally?
  • Most of the dependency versions are out of date.
  • registerServiceWorker.js is missing

I'm guessing these issues will be resolved after rebasing on Facebook's latest changes.

Facebook create-react-app
"dependencies": {
    "autoprefixer": "7.1.6",
    "babel-core": "6.26.0",
    "babel-eslint": "7.2.3",
    "babel-jest": "20.0.3",
    "babel-loader": "7.1.2",
    "babel-preset-react-app": "^3.1.0",
    "babel-runtime": "6.26.0",
    "case-sensitive-paths-webpack-plugin": "2.1.1",
    "chalk": "1.1.3",
    "css-loader": "0.28.7",
    "dotenv": "4.0.0",
    "eslint": "4.10.0",
    "eslint-config-react-app": "^2.0.1",
    "eslint-loader": "1.9.0",
    "eslint-plugin-flowtype": "2.39.1",
    "eslint-plugin-import": "2.8.0",
    "eslint-plugin-jsx-a11y": "5.1.1",
    "eslint-plugin-react": "7.4.0",
    "extract-text-webpack-plugin": "3.0.2",
    "file-loader": "1.1.5",
    "fs-extra": "3.0.1",
    "html-webpack-plugin": "2.29.0",
    "jest": "20.0.4",
    "object-assign": "4.1.1",
    "postcss-flexbugs-fixes": "3.2.0",
    "postcss-loader": "2.0.8",
    "promise": "8.0.1",
    "raf": "3.4.0",
    "react": "^16.0.0",
    "react-dev-utils": "^4.2.1",
    "react-dom": "^16.0.0",
    "style-loader": "0.19.0",
    "sw-precache-webpack-plugin": "0.11.4",
    "url-loader": "0.6.2",
    "webpack": "3.8.1",
    "webpack-dev-server": "2.9.4",
    "webpack-manifest-plugin": "1.3.2",
    "whatwg-fetch": "2.0.3"
  },
wmonk create-react-app
"dependencies": {
    "autoprefixer": "7.1.2",
    "case-sensitive-paths-webpack-plugin": "2.1.1",
    "chalk": "1.1.3",
    "css-loader": "0.28.4",
    "dotenv": "4.0.0",
    "extract-text-webpack-plugin": "3.0.0",
    "file-loader": "0.11.2",
    "fs-extra": "3.0.1",
    "html-webpack-plugin": "2.29.0",
    "jest": "20.0.4",
    "object-assign": "4.1.1",
    "postcss-flexbugs-fixes": "3.2.0",
    "postcss-loader": "2.0.6",
    "promise": "8.0.1",
    "react": "^16.0.0",
    "react-dev-utils": "^4.0.1",
    "react-dom": "^16.0.0",
    "source-map-loader": "^0.2.1",
    "style-loader": "0.18.2",
    "sw-precache-webpack-plugin": "0.11.4",
    "ts-jest": "^20.0.7",
    "ts-loader": "^2.3.7",
    "tslint": "^5.7.0",
    "tslint-loader": "^3.5.3",
    "tslint-react": "^3.2.0",
    "typescript": "~2.5.3",
    "url-loader": "0.5.9",
    "webpack": "3.5.1",
    "webpack-dev-server": "2.7.1",
    "webpack-manifest-plugin": "1.2.1",
    "whatwg-fetch": "2.0.3"
  },
@bootstraponline
Copy link
Author

bootstraponline commented Nov 5, 2017

Why is the entire create-react-app repo forked? It looks like only the react-scripts package is required.

I rebased the create-react-app-typescript on upstream create-react-app and it seems to work.

git clone https://github.com/facebookincubator/create-react-app.git
cd create-react-app/packages/react-dev-utils
yarn
yarn link
cd my_app
yarn link "react-dev-utils"
yarn start

@ianschmitz
Copy link
Contributor

raf was just added recently to CRA I believe to fix Jest errors. registerServiceWorker.ts is part of the template.

@bootstraponline
Copy link
Author

I'm working on updating in this PR #183

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants