Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in response bodies #315

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 26, 2021

And also clean up the way we manage XMLHttpRequest's response, which allows for simplifying "handle response end-of-body" and "handle errors".

Tests: web-platform-tests/wpt#27778.

Fixes #314.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

And also clean up the way we manage XMLHttpRequest's response, which allows for simplifying "handle response end-of-body" and "handle errors".

Tests: web-platform-tests/wpt#27778.

Fixes #314.
@annevk annevk requested a review from yutakahirano February 26, 2021 14:16
@annevk
Copy link
Member Author

annevk commented Feb 26, 2021

(@domenic I think this ends up fixing something you mentioned in passing as well about the response parameter. The whole thing is still a bit clunky, but this makes it a lot better.)

@annevk
Copy link
Member Author

annevk commented Mar 2, 2021

@yutakahirano is this on your radar?

@yutakahirano
Copy link
Member

Oh sorry, I'm looking...

xhr.bs Show resolved Hide resolved
xhr.bs Show resolved Hide resolved
@annevk annevk merged commit 231e282 into main Mar 3, 2021
@annevk annevk deleted the annevk/response-body-errors branch March 3, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Handle error while reading response body in synchronous XHR
2 participants