XMLHttpRequest: response stream errors #27778
Merged
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://crbug.com/602051 Service worker doesn't intercept sync XHR requests. cc: @domfarolino We can write a test with https://github.com/web-platform-tests/wpt/blob/master/fetch/api/resources/bad-chunk-encoding.py alternatively. |
|
@yutakahirano thanks for identifying that! I was wondering if there were non-ReadableStream ways to trigger this condition. That will make testing less cumbersome going forward and also reduces my worry about this being not handled well across callers (although most specification callers of fetch do not seem to account for it at the moment). |
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Feb 26, 2021
And also clean up the way we manage XMLHttpRequest's response, which allows for simplifying "handle response end-of-body" and "handle errors". Tests: web-platform-tests/wpt#27778. Fixes #314.
3 tasks
annevk
added a commit
to whatwg/xhr
that referenced
this pull request
Mar 3, 2021
And also clean up the way we manage XMLHttpRequest's response, which allows for simplifying "handle response end-of-body" and "handle errors". (Also ends up removing the remaining dependency on Streams.) Tests: web-platform-tests/wpt#27778. Fixes #314.
Bishwarupjee
pushed a commit
to Bishwarupjee/xhr
that referenced
this pull request
Jan 31, 2024
And also clean up the way we manage XMLHttpRequest's response, which allows for simplifying "handle response end-of-body" and "handle errors". (Also ends up removing the remaining dependency on Streams.) Tests: web-platform-tests/wpt#27778. Fixes #314.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/xhr#314.
It seems Chrome does not throw exceptions here at all...