Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error while reading response body in synchronous XHR #314

Closed
yutakahirano opened this issue Feb 25, 2021 · 1 comment · Fixed by #315
Closed

Handle error while reading response body in synchronous XHR #314

yutakahirano opened this issue Feb 25, 2021 · 1 comment · Fixed by #315

Comments

@yutakahirano
Copy link
Member

Currently the error is ignored, which is not good.
annevk added a commit to web-platform-tests/wpt that referenced this issue Feb 25, 2021
@annevk
XMLHttpRequest: response stream errors
ee00915 
For whatwg/xhr#314.
@annevk annevk mentioned this issue Feb 25, 2021
Merged
@annevk
Copy link
Member

annevk commented Feb 25, 2021

I guess I also need to test the asynchronous case as basically https://xhr.spec.whatwg.org/#handle-errors doesn't make a whole lot of sense. Or do we already have tests for that?

annevk added a commit that referenced this issue Feb 26, 2021
@annevk
Use Fetch's body read algorithms
26f974f 
Follow-up: #314.
annevk added a commit that referenced this issue Feb 26, 2021
@annevk
Handle errors in response bodies
2a60fc0 
And also clean up the way we manage XMLHttpRequest's response, which allows for simplifying "handle response end-of-body" and "handle errors".

Tests: web-platform-tests/wpt#27778.

Fixes #314.
@annevk annevk mentioned this issue Feb 26, 2021
Merged
3 tasks
annevk added a commit to web-platform-tests/wpt that referenced this issue Mar 2, 2021
@annevk
XMLHttpRequest: response stream errors
57ceb7e 
For whatwg/xhr#314.
annevk added a commit that referenced this issue Mar 3, 2021
@annevk
Handle errors in response bodies
231e282 
And also clean up the way we manage XMLHttpRequest's response, which allows for simplifying "handle response end-of-body" and "handle errors". (Also ends up removing the remaining dependency on Streams.)

Tests: web-platform-tests/wpt#27778.

Fixes #314.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 15, 2021
@annevk @moz-wptsync-bot
Bug 1694952 [wpt PR 27778] - XMLHttpRequest: response stream errors, …
5528343 
…a=testonly

Automatic update from web-platform-tests
XMLHttpRequest: response stream errors

For whatwg/xhr#314.
--

wpt-commits: 57ceb7e5521452bbc67afb75d130c40980e48a11
wpt-pr: 27778
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Mar 15, 2021
@marco-c
Bug 1694952 [wpt PR 27778] - XMLHttpRequest: response stream errors, …
59073ad 
…a=testonly

Automatic update from web-platform-tests
XMLHttpRequest: response stream errors

For whatwg/xhr#314.
--

wpt-commits: 57ceb7e5521452bbc67afb75d130c40980e48a11
wpt-pr: 27778

UltraBlame original commit: 5ff73d61dcf3523bf8e1d1b9b8e0695b2b123c93
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Mar 15, 2021
@marco-c
Bug 1694952 [wpt PR 27778] - XMLHttpRequest: response stream errors, …
7a19f6a 
…a=testonly

Automatic update from web-platform-tests
XMLHttpRequest: response stream errors

For whatwg/xhr#314.
--

wpt-commits: 57ceb7e5521452bbc67afb75d130c40980e48a11
wpt-pr: 27778

UltraBlame original commit: 5ff73d61dcf3523bf8e1d1b9b8e0695b2b123c93
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Mar 15, 2021
@marco-c
Bug 1694952 [wpt PR 27778] - XMLHttpRequest: response stream errors, …
3ab5d06 
…a=testonly

Automatic update from web-platform-tests
XMLHttpRequest: response stream errors

For whatwg/xhr#314.
--

wpt-commits: 57ceb7e5521452bbc67afb75d130c40980e48a11
wpt-pr: 27778

UltraBlame original commit: 5ff73d61dcf3523bf8e1d1b9b8e0695b2b123c93
@whatwg whatwg deleted a comment from mobinskyman Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle errors in response bodies whatwg/xhr
2 participants
@annevk @yutakahirano