Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify WebTransport BFCache interaction #9217

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

nidhijaju
Copy link
Contributor

@nidhijaju nidhijaju commented Apr 26, 2023

Based on w3c/webtransport#500 (comment), this PR explicitly calls the "context cleanup steps" in the WebTransport spec from within the HTML spec's "unloading document cleanup steps".

cc @rakina

(See WHATWG Working Mode: Changes for more details.)


/acknowledgements.html ( diff )
/document-lifecycle.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )

@rakina
Copy link
Member

rakina commented Apr 26, 2023

Thanks a lot for the quick work here! Non-owner LGTM :)

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good with minor editorial issues! I think WebTransport has other implementers involved too, right, so more than just Chrome can be said to be interested in this?

Web platform tests would also be good, ideally ones that show that WebTransport shutdown happens after WebSocket shutdown but before EventSource shutdown, since that's where you placed this.

source Show resolved Hide resolved
source Show resolved Hide resolved
@nidhijaju
Copy link
Contributor Author

@jesup or @jan-ivar, can we say Mozilla is also interested in this?

@jan-ivar
Copy link
Contributor

Yes Mozilla is interested.

@nidhijaju
Copy link
Contributor Author

I've updated the PR description with this information as well, but we have implementer interest from Mozilla now, and there are some WPTs at web-platform-tests/wpt#40117. Does this look good to you, @domenic?

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@domenic domenic merged commit 47d6546 into whatwg:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants