Make document unsalvageable #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I realized there is lots of random changes included in this pr. Let me remove them now. |
rubberyuzu
force-pushed
the
make-document-unsalvageable
branch
from
c89cadc
to
040cbc5
Compare
|
Now all the unrelated changes are gone, PTAL @rakina |
rakina
reviewed
May 25, 2023
There was a problem hiding this comment.
Thanks, and sorry for the late review! BTW [there](whatwg#9217 might land soon, so you might want to add a reason for WebTransport soon.
|
Thanks, PTAL again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds "make document unsalvageable" function and uses the function in multiple places.
The html version of the change is available in this draft pr: whatwg#9324
PTAL! @rakina