Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BFCache interaction #503

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

nidhijaju
Copy link
Member

@nidhijaju nidhijaju commented Apr 26, 2023

As mentioned in #500 (comment), the BFCache guidance was recently updated to say we should define a stand-alone set of steps, that the HTML spec explicitly calls out to at unloading-document-cleanup time. This PR updates the spec based on this guidance, in coordination with whatwg/html#9217.

cc @rakina


Preview | Diff

@nidhijaju nidhijaju requested review from ricea and aboba April 26, 2023 03:05
@rakina
Copy link
Member

rakina commented Apr 26, 2023

Thanks a lot for the quick work here! Non-owner LGTM here as well :)

Copy link
Contributor

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ekinnear ekinnear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-ivar
Copy link
Member

@jesup LGTY?

@jesup
Copy link
Collaborator

jesup commented May 11, 2023

LGTM

@jan-ivar jan-ivar merged commit 43588f1 into w3c:main May 23, 2023
github-actions bot added a commit that referenced this pull request May 23, 2023
SHA: 43588f1
Reason: push, by jan-ivar

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nidhijaju nidhijaju deleted the bfcache-wt-interaction2 branch May 23, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants