Make <img>.complete more reliable #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are in line with all three browsers. Chrome still diverges significantly from the standard & tests though on other aspects. Tests: web-platform-tests/wpt#19298. Fixes #1055, fixes #4475. #4476 remains outstanding.
This was referenced Sep 25, 2019
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 25, 2019
Align them somewhat with more modern practices and fix one test that expects img.complete to change during a while loop. Helps with whatwg/html#1055 and issues pointed out from there. whatwg/html#4934 has proposed HTML Standard changes.
annevk
commented
Sep 25, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 30, 2019
…tonly Automatic update from web-platform-tests HTML: update <img>.complete tests Align them somewhat with more modern practices and fix one test that expects img.complete to change during a while loop. Helps with whatwg/html#1055 and issues pointed out from there. whatwg/html#4934 has proposed HTML Standard changes. -- wpt-commits: dc2e245a955c832e88d24e6a1af5f718da5491bd wpt-pr: 19298
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Sep 30, 2019
…tonly Automatic update from web-platform-tests HTML: update <img>.complete tests Align them somewhat with more modern practices and fix one test that expects img.complete to change during a while loop. Helps with whatwg/html#1055 and issues pointed out from there. whatwg/html#4934 has proposed HTML Standard changes. -- wpt-commits: dc2e245a955c832e88d24e6a1af5f718da5491bd wpt-pr: 19298
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…tonly Automatic update from web-platform-tests HTML: update <img>.complete tests Align them somewhat with more modern practices and fix one test that expects img.complete to change during a while loop. Helps with whatwg/html#1055 and issues pointed out from there. whatwg/html#4934 has proposed HTML Standard changes. -- wpt-commits: dc2e245a955c832e88d24e6a1af5f718da5491bd wpt-pr: 19298 UltraBlame original commit: c775395917748fc6bf05f54e385767b974109d4a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…tonly Automatic update from web-platform-tests HTML: update <img>.complete tests Align them somewhat with more modern practices and fix one test that expects img.complete to change during a while loop. Helps with whatwg/html#1055 and issues pointed out from there. whatwg/html#4934 has proposed HTML Standard changes. -- wpt-commits: dc2e245a955c832e88d24e6a1af5f718da5491bd wpt-pr: 19298 UltraBlame original commit: c775395917748fc6bf05f54e385767b974109d4a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 5, 2019
…tonly Automatic update from web-platform-tests HTML: update <img>.complete tests Align them somewhat with more modern practices and fix one test that expects img.complete to change during a while loop. Helps with whatwg/html#1055 and issues pointed out from there. whatwg/html#4934 has proposed HTML Standard changes. -- wpt-commits: dc2e245a955c832e88d24e6a1af5f718da5491bd wpt-pr: 19298 UltraBlame original commit: c775395917748fc6bf05f54e385767b974109d4a
|
Okay, comment removed, I think this is good now. I'll file a Chrome bug as the tests have landed already: |
zcorpan
approved these changes
Oct 15, 2019
4 tasks
|
@annevk Sorry for the lag here... These changes are fine as far as they go, but they still don't end up matching UAs, because in the spec the pending request is completed async, off a stable state, while all UAs start returning |
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 2, 2019
…-img-completion, r=<try>
Account for pending request state in <img>.complete
Per spec update, if the \<img\> current request is completely available or broken, `complete` is only `true` if the \<img\>'s pending request is also unavailable.
> The IDL attribute complete must return true if any of the following conditions is true:
* Both the src attribute and the srcset attribute are omitted.
* The srcset attribute is omitted and the src attribute's value is the empty string.
* **The img element's current request's state is completely available and its pending request is null.**
* **The img element's current request's state is broken and its pending request is null.**
Spec diff: https://whatpr.org/html/4934/1ab7c86...02772ea/embedded-content.html#the-img-element
#24450
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24450.
- [x] These changes do not require tests because they _should_ be covered by the automatically synced WPT associated with the spec update at whatwg/html#4934.
However, the [test updated with the spec change](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/img.complete.html) passes before and after this PR. Should another test be added?
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 7, 2019
…-img-completion, r=<try>
Account for pending request state in <img>.complete
Per spec update, if the \<img\> current request is completely available or broken, `complete` is only `true` if the \<img\>'s pending request is also unavailable.
> The IDL attribute complete must return true if any of the following conditions is true:
* Both the src attribute and the srcset attribute are omitted.
* The srcset attribute is omitted and the src attribute's value is the empty string.
* **The img element's current request's state is completely available and its pending request is null.**
* **The img element's current request's state is broken and its pending request is null.**
Spec diff: https://whatpr.org/html/4934/1ab7c86...02772ea/embedded-content.html#the-img-element
#24450
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24450.
- [x] These changes do not require tests because they _should_ be covered by the automatically synced WPT associated with the spec update at whatwg/html#4934.
However, the [test updated with the spec change](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/img.complete.html) passes before and after this PR. Should another test be added?
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 12, 2019
…-img-completion, r=<try>
Account for pending request state in <img>.complete
Per spec update, if the \<img\> current request is completely available or broken, `complete` is only `true` if the \<img\>'s pending request is also unavailable.
> The IDL attribute complete must return true if any of the following conditions is true:
* Both the src attribute and the srcset attribute are omitted.
* The srcset attribute is omitted and the src attribute's value is the empty string.
* **The img element's current request's state is completely available and its pending request is null.**
* **The img element's current request's state is broken and its pending request is null.**
Spec diff: https://whatpr.org/html/4934/1ab7c86...02772ea/embedded-content.html#the-img-element
#24450
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24450.
- [x] These changes do not require tests because they _should_ be covered by the automatically synced WPT associated with the spec update at whatwg/html#4934.
However, the [test updated with the spec change](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/img.complete.html) passes before and after this PR. Should another test be added?
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 12, 2019
…-img-completion, r=<try>
Account for pending request state in <img>.complete
Per spec update, if the \<img\> current request is completely available or broken, `complete` is only `true` if the \<img\>'s pending request is also unavailable.
> The IDL attribute complete must return true if any of the following conditions is true:
* Both the src attribute and the srcset attribute are omitted.
* The srcset attribute is omitted and the src attribute's value is the empty string.
* **The img element's current request's state is completely available and its pending request is null.**
* **The img element's current request's state is broken and its pending request is null.**
Spec diff: https://whatpr.org/html/4934/1ab7c86...02772ea/embedded-content.html#the-img-element
#24450
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24450.
- [x] These changes do not require tests because they _should_ be covered by the automatically synced WPT associated with the spec update at whatwg/html#4934.
However, the [test updated with the spec change](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/img.complete.html) passes before and after this PR. Should another test be added?
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This was referenced Apr 13, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are in line with all three browsers. Chrome still diverges significantly from the standard & tests though on other aspects.
Tests: web-platform-tests/wpt#19298.
Fixes #1055, fixes #4475. #4476 remains outstanding.
(See WHATWG Working Mode: Changes for more details.)
/embedded-content.html ( diff )