Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<img>.complete should be changed by the "update the image data" algorithm #4476

Closed
domenic opened this issue Mar 29, 2019 · 4 comments
Closed

<img>.complete should be changed by the "update the image data" algorithm #4476

domenic opened this issue Mar 29, 2019 · 4 comments
Labels
topic: img

Comments

@domenic
Copy link
Member

domenic commented Mar 29, 2019

Ported from https://www.w3.org/Bugs/Public/show_bug.cgi?id=26113

<img>.complete should be changed by "update the image data" algorithm
The current spec appears to be wrong at least immediately after setting src
and the image was not in cache.

Also see https://bugzilla.mozilla.org/show_bug.cgi?id=960360

.complete is broken in other ways: #1055 and #4475.
@EdgarChen EdgarChen mentioned this issue Sep 4, 2019
Open
annevk added a commit that referenced this issue Sep 25, 2019
@annevk
Make <img>.complete more reliable
9da1b2d 
These changes are in line with all three browsers. Chrome still diverges significantly from the standard & tests though on other aspects.

Tests: web-platform-tests/wpt#19298.

Fixes #1055, fixes #4475. #4476 remains outstanding.
@annevk annevk mentioned this issue Sep 25, 2019
Merged
3 tasks
@annevk
Copy link
Member

annevk commented Sep 25, 2019

It would be great to have a description of the problem that remains here in light of #4934.

@zcorpan
Copy link
Member

zcorpan commented Sep 25, 2019

My thinking is that having the algorithm update complete directly would more clearly map to implementation, and thus be easier to reason about.

@annevk
Copy link
Member

annevk commented Sep 25, 2019

Well the processing model updates img state and complete reflects that state per my PR. Adding additional state specifically for complete might be warranted, but it seems better if it can be expressed in terms of existing state.

annevk added a commit that referenced this issue Oct 15, 2019
@annevk
Make <img>.complete more reliable
87fa719 
These changes are in line with all three browsers. Chrome still diverges significantly from the standard & tests though on other aspects.

Tests: web-platform-tests/wpt#19298.

Fixes #1055, fixes #4475. #4476 remains outstanding.
@annevk
Copy link
Member

annevk commented Oct 22, 2019

Let's merge this into #4884.

@annevk annevk closed this as completed Oct 22, 2019
zcorpan pushed a commit that referenced this issue Nov 6, 2019
@annevk @zcorpan
Make <img>.complete more reliable
2af48f3 
These changes are in line with all three browsers. Chrome still diverges significantly from the standard & tests though on other aspects.

Tests: web-platform-tests/wpt#19298.

Fixes #1055, fixes #4475. #4476 remains outstanding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: img
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zcorpan @domenic @annevk