Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How should <img>.complete interact with pending requests? #4475

Closed
domenic opened this issue Mar 29, 2019 · 0 comments · Fixed by #4934
Closed

How should <img>.complete interact with pending requests? #4475

domenic opened this issue Mar 29, 2019 · 0 comments · Fixed by #4934
Labels
topic: img

Comments

@domenic
Copy link
Member

domenic commented Mar 29, 2019 •
edited
Loading

Ported from https://www.w3.org/Bugs/Public/show_bug.cgi?id=27484, where @bzbarsky says:

It's not clear to me how .complete should interact with pending requests, because the definition of "complete" is in terms of "completely available" and "completely available" doesn't make it clear whether the data being talked about is the current or pending data.

As a simple proposal, we could make .complete be false if there is a pending request at all...

That sounds nice and simple, but we'd need tests and to ensure it's not too incompatible with current browsers.

Note that .complete is broken in other ways too: #1055
@domenic domenic mentioned this issue Mar 29, 2019
Closed
@annevk annevk mentioned this issue Sep 25, 2019
Open
annevk added a commit that referenced this issue Sep 25, 2019
@annevk
Make <img>.complete more reliable
9da1b2d 
These changes are in line with all three browsers. Chrome still diverges significantly from the standard & tests though on other aspects.

Tests: web-platform-tests/wpt#19298.

Fixes #1055, fixes #4475. #4476 remains outstanding.
@annevk annevk mentioned this issue Sep 25, 2019
Merged
3 tasks
annevk added a commit that referenced this issue Oct 15, 2019
@annevk
Make <img>.complete more reliable
87fa719 
These changes are in line with all three browsers. Chrome still diverges significantly from the standard & tests though on other aspects.

Tests: web-platform-tests/wpt#19298.

Fixes #1055, fixes #4475. #4476 remains outstanding.
zcorpan pushed a commit that referenced this issue Nov 6, 2019
@annevk @zcorpan
Make <img>.complete more reliable
2af48f3 
These changes are in line with all three browsers. Chrome still diverges significantly from the standard & tests though on other aspects.

Tests: web-platform-tests/wpt#19298.

Fixes #1055, fixes #4475. #4476 remains outstanding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: img
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make <img>.complete more reliable whatwg/html
1 participant
@domenic