Merge URLUtils into Location #221
Conversation
| @@ -80958,6 +80967,317 @@ State: <OUTPUT NAME=I>1</OUTPUT> <INPUT VALUE="Increment" TYPE=BUTTON O | |||
| <p>The <i>relevant <code>Document</code></i> is the <code>Location</code> object's associated | |||
| <code>Document</code> object's <span>browsing context</span>'s <span>active document</span>.</p> | |||
|
|
|||
| <p>The <code>Location</code> object's <i>url</i> is the <i>relevant <code>Document</code></i>'s | |||
There was a problem hiding this comment.
#219 used a <dfn>, not an <i>, to associate an internal slot.
|
I think I addressed all feedback. |
|
|
||
| <dt><var>location</var> . <code subdfn data-x="dom-hyperlink-search">search</code></dt> |
There was a problem hiding this comment.
I think for search and hash it would be especially valuable to point out the preceding ? or #.
|
One of these two PRs should remove the reference to URLUtils in the references section. Maybe that's a follow-up commit that cleans up that section in general, e.g. adding data-x-href as well for those terms missing it. |
|
I would like to merge a/area first. Then remove all the redundant things with this PR, such as 32a7a20. |
The URLUtils abstraction is not working out. See #164 and whatwg/url#62 for details.
|
I think this is ready now. |
| @@ -1142,8 +1142,8 @@ | |||
| ways:</p> | |||
|
|
|||
| <pre>var a = <span data-x="Document">document</span>.<span data-x="dom-document-links">links</span>[0]; // obtain the first link in the document | |||
| a.<span data-x="dom-url-href">href</span> = 'sample.html'; // change the destination URL of the link | |||
| a.<span data-x="dom-url-protocol">protocol</span> = 'https'; // change just the scheme part of the URL | |||
| a.<span data-x="dom-hyperlink-href">href</span> = 'sample.html'; // change the destination URL of the link | |||
There was a problem hiding this comment.
Should these actually link to the setter?
There was a problem hiding this comment.
The setter? That doesn't have its own <dfn>.
There was a problem hiding this comment.
It seems like it would be nice if it did, but probably too big of a departure from the rest of the spec.
|
LGTM when the missing "must" is fixed. Would be good to look into setter vs. getter links and the bug links in the sidebar, but not necessary. |
This fixes the HTML standard side of these issues: * whatwg/url#61 * whatwg/url#62 There is still some cleanup work left on the URL side, e.g., making sure the basic URL parser returns failure for certain conditions when override state is scheme start state.
This is a series of improvements that will help pave the way for a better CI build/deploy architecture in the future, potentially based on GitHub Actions. In particular: * Stop grabbing pdfsizeopt using git from outside the container. Instead, get it as part of the Dockerfile along with other dependencies. Closes whatwg#221. * Avoid the multi-step PDF generation process, where we deploy to whatwg.org, point Prince at that, and then deploy the generated print.pdf to whatwg.org. Instead, we serve the built output inside the Docker container, use that to generate print.pdf, and deploy everything to whatwg.org in a single step. * Update Prince from v11.3 to v13.5. * Download only the .jar file for the validator, instead of the full package; we can let Docker handle installing Java.
This fixes the HTML standard side of these issues:
There is still some cleanup work left on the URL side, e.g., making
sure the basic URL parser returns failure for certain conditions when
override state is scheme start state.