-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLUtils is wrong for Location object #61
Comments
|
This fixes the HTML standard side of these issues: * whatwg/url#61 * whatwg/url#62 There is still some cleanup work left on the URL side, e.g., making sure the basic URL parser returns failure for certain conditions when override state is scheme start state.
This fixes the HTML standard side of these issues: * whatwg/url#61 * whatwg/url#62 There is still some cleanup work left on the URL side, e.g., making sure the basic URL parser returns failure for certain conditions when override state is scheme start state.
This fixes the HTML standard side of these issues: * whatwg/url#61 * whatwg/url#62 There is still some cleanup work left on the URL side, e.g., making sure the basic URL parser returns failure for certain conditions when override state is scheme start state.
This fixes the HTML standard side of these issues: * whatwg/url#61 * whatwg/url#62 There is still some cleanup work left on the URL side, e.g., making sure the basic URL parser returns failure for certain conditions when override state is scheme start state.
This has been fixed in HTML. |
I think the invalid protocols still needs to be fixed unfortunately. Requires some further study. |
Looking at the setter in https://html.spec.whatwg.org/multipage/browsers.html#dom-location-protocol it seems to anticipate a change in the URL Standard where we sometimes return failure for bogus schemes. That will then result in an exception. I've also noticed that browsers will change the scheme of data URLs and attempt to navigate, which would go against the HTML Standard. They also appear to use DOMException "SyntaxError" rather than TypeError. The exception we should probably change in the HTML Standard, but browsers might want to update to change the scheme less overall. |
See whatwg/url#61 for context.
See whatwg/url#61 for context. #4412 tests broken schemes.
Once those tests lands this can be closed once bugs have been filed against browsers. |
This matches Chrome and Safari. Edge and Firefox use an internal error that needs to change either way. Tests: web-platform-tests/wpt#4412. Additional context: whatwg/url#61.
This matches Blink and WebKit. Edge and Gecko use an internal error that needs to change either way. Tests: web-platform-tests/wpt#4412. Additional context: whatwg/url#61.
See whatwg/url#61 for context.
See whatwg/url#61 for context. #4412 tests broken schemes.
This matches Blink and WebKit. Edge and Gecko use an internal error that needs to change either way. Tests: web-platform-tests/wpt#4412. Additional context: whatwg/url#61.
The
Location
object probably requires special treatment since setting its setters do not actually change the underlying URL directly. They just cause navigation. And the last navigation seems to win, too:Navigates to a URL with a new scheme, not a new path.
The text was updated successfully, but these errors were encountered: