Inline URLUtils for a and area elements #219
Conversation
|
Note to self: make this consistent about "the element" vs "element" (former is better). |
| <h4>API for <code>a</code> and <code>area</code> elements</h4> | ||
|
|
||
| <pre class="idl">[NoInterfaceObject, Exposed=Window] | ||
| interface <dfn>HTMLHyperLinkElement</dfn> { |
There was a problem hiding this comment.
Name should not contain HyperLink; it should be Hyperlink. The document uses hyperlink as all one word, not two words.
Maybe name it with a "mixin" suffix, or "utils"? Everything following the HTML___Element pattern is an actual class, not a mixin. So e.g. HTMLHyperlinkUtils or HTMLHyperlinkElementUtils would help clarify IMO.
I would actually prefer "this element" :) |
| <li><p>If <var>url</var> or <var>url</var>'s <span data-x="concept-url-host">host</span> is null, | ||
| or <var>url</var>'s <span>non-relative flag</span> is set, terminate these steps.</p></li> | ||
|
|
||
| <li><p><span>Set the username</span>, given <var>url</var> and the given value.</p></li> |
There was a problem hiding this comment.
Minor: there is some inconsistency in how you call other specs algorithms. Here it is "given url and the given value", i.e. as positional arguments. Later it is "with url as url and host state as state override," i.e. named arguments. Might be better to stick to named arguments everywhere.
There was a problem hiding this comment.
I use named arguments when it gets ambiguous. Would love to get rid of that though. Hopefully at some point we have a good meta-language for writing algorithms that has all this stuff covered.
|
All comments should have been addressed. I left them as separate commits for now. |
| data-noexport="" data-x="concept-hyperlink-url-set">set the url</dfn> algorithm, which sets this | ||
| element's <span data-x="concept-hyperlink-url">url</span> to the <span>resulting parsed URL</span> | ||
| of <span data-x="resolve a url">resolving</span> this element's <code | ||
| data-x="attr-hyperlink-href">href</code> content attribute value relative to element. If <span |
There was a problem hiding this comment.
relative to element -> relative to this element
|
LGTM after fixing the ? vs. # confusion. |
See whatwg/url#62 for the background. This defines a mixin used by both a and area elements to define their IDL members previously defined by the URL standard. It also fixes a small error in the WorkerLocation text.
whatwg#219 fixed this for the CI Dockerfile.
See whatwg/url#62 for the background. This
defines a mixin used by both a and area elements to define their IDL
members previously defined by the URL standard.
It also fixes a small error in the WorkerLocation text.