-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: π defaults flag behaviour #1323
Conversation
Thank you for your pull request! The most important CI builds succeeded, weβll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
9403cea
@anshumanv can you resolve conflicts? |
Do we wish to support this @webpack/cli-team? |
@anshumanv we need investigate what does this option do, most likely we will remove it |
@evilebottnawi when passed, default config is merged with the supplied config by the user https://github.com/webpack/webpack-cli/blob/dfb9a9142706751617eb38dc9f3e00f8ec750ec9/packages/webpack-cli/lib/utils/development-config.js or https://github.com/webpack/webpack-cli/blob/dfb9a9142706751617eb38dc9f3e00f8ec750ec9/packages/webpack-cli/lib/utils/production-config.js Not sure of the use case |
Should we remove it then? |
Yes, no need, let's remove, webpack already has good default values |
Okay, closing and removing in next PR. π |
β Closes: #1322
What kind of change does this PR introduce?
Fix the application of default flags
Did you add tests for your changes?
Yes, enabled
If relevant, did you update the documentation?
Not needed
Summary
Does this PR introduce a breaking change?
No.
Other information