Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 remove defaults flag #1543

Merged
merged 3 commits into from
May 15, 2020

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented May 13, 2020

drop support for defaults flag

What kind of change does this PR introduce?

Drop support for defaults flag.

Did you add tests for your changes?
Removed corresponding tests

If relevant, did you update the documentation?
Yes

Summary

Does this PR introduce a breaking change?
Shouldn't break anything.

Other information

drop support for defaults flag
@anshumanv anshumanv marked this pull request as ready for review May 13, 2020 18:18
@anshumanv anshumanv requested a review from a team as a code owner May 13, 2020 18:18
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good job!

@alexander-akait
Copy link
Member

/cc @webpack/cli-team

@snitin315
Copy link
Member

One more place to remove => docs

@anshumanv
Copy link
Member Author

anshumanv commented May 14, 2020

Removed 👍, good find!

@alexander-akait alexander-akait merged commit a905590 into webpack:next May 15, 2020
@alexander-akait
Copy link
Member

Good job! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants