refactor: 💡 remove defaults flag #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop support for defaults flag
|
/cc @webpack/cli-team |
|
One more place to remove => docs |
|
Removed 👍, good find! |
snitin315
approved these changes
May 14, 2020
shivaylamba
approved these changes
May 14, 2020
rishabh3112
approved these changes
May 15, 2020
alexander-akait
approved these changes
May 15, 2020
|
Good job! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop support for defaults flag
What kind of change does this PR introduce?
Drop support for defaults flag.
Did you add tests for your changes?
Removed corresponding tests
If relevant, did you update the documentation?
Yes
Summary
Does this PR introduce a breaking change?
Shouldn't break anything.
Other information