docs: fix typo in --defaults description #1540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
requested changes
May 13, 2020
webpack-bot
added
PR: reviewed-changes-requested
PR: review-outdated
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
|
I think we should add a snapshot test for |
snitin315
changed the title
I think what we have now for |
|
We'll be removing this flag as per discussion in #1323 |
I'm happy to send a PR for that as well, if you agree. |
|
WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
typo fix
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
YES
Summary
aggresivelyaggressivelyDoes this PR introduce a breaking change?
NO
Other information
NA