chore: use compilation.getCache() instead of compilation.cache #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 5 5
Lines 403 403
Branches 154 154
=======================================
Hits 375 375
Misses 27 27
Partials 1 1
Continue to review full report at Codecov.
|
Co-authored-by: Ryan Clark <[email protected]>
snitin315
force-pushed
the
fix/depreciation-warning
branch
from
693987c to
3bdb9f8
Compare
6 tasks
sokra
requested changes
Aug 3, 2020
| @@ -11,7 +11,7 @@ export default class Cache { | |||
| } | |||
|
|
|||
| isEnabled() { | |||
| return Boolean(this.compilation.cache); | |||
| return Boolean(this.compilation.getCache()); | |||
There was a problem hiding this comment.
Suggested change
| return Boolean(this.compilation.getCache()); | |
| return true; |
This always exists and getCache() always returns something.
It's not detectable if the cache is enabled. When no memory cache or filesystem cache is attached cache.get always returns undefined and store does nothing. Is this needed to be detectable? @evilebottnawi
There was a problem hiding this comment.
I will add tests on this, but I think it is unnecessary
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Breaking Changes
Remove deprecated method
Additional Info
Refers webpack/webpack-cli#1724 (comment) webpack/webpack-cli#1724 (comment)