-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add tests for optimization mangleExports #1724
Conversation
0789318
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anshumanv with a new release (v5.0.0-beta.23
) now webpack exports --optimization-mangle-exports
, so it will be automatically tested inside coreFlags/optimization-flags.test.js
. So we need to modify it there.
This new addition is the reason for CI failure (and some deprecation warnings).
Can you fix it?
A new warning popped up in various tests, all need update |
/cc @webpack/cli-team several tests are failing because the next version of webpack is throwing a warning so all the |
I think we need to investigate where is the warning coming from and fix it. The waring is something like
|
Feel free to investigate and PR @snitin315 |
@anshumanv the warning is coming from |
Now we wait for merge and release /cc @evilebottnawi |
Awesome, thanks for the effort! 👏 |
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
A case was reported by the user in #1677 add tests for it
Does this PR introduce a breaking change?
No
Other information
fixes #1677