Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with webpack@5 #286

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 3, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

avoid deprecation

Breaking Changes

In theory yes, but only for webpack@5, but because webpack@5 is in beta, you need to update webpack to latest version

Additional Info

fixes #284, fixes #277

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #286 into master will increase coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   93.05%   93.52%   +0.47%     
==========================================
  Files           5        5              
  Lines         403      386      -17     
  Branches      154      151       -3     
==========================================
- Hits          375      361      -14     
+ Misses         27       24       -3     
  Partials        1        1              
Impacted Files Coverage Δ
src/Webpack4Cache.js 100.00% <100.00%> (ø)
src/Webpack5Cache.js 100.00% <100.00%> (+9.67%) ⬆️
src/index.js 94.79% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5acaa...b811071. Read the comment docs.

@alexander-akait alexander-akait merged commit 5d2bd29 into master Aug 3, 2020
@alexander-akait alexander-akait deleted the fix-compatibility-with-webpack@5 branch August 3, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant