Event serializers and views improvements #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`user_reg` is now included in `EventReadSerializer`
ivarnakken
added
review-needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3699 +/- ##
==========================================
- Coverage 89.60% 89.60% -0.01%
==========================================
Files 700 700
Lines 22430 22422 -8
==========================================
- Hits 20099 20091 -8
Misses 2331 2331 ☔ View full report in Codecov by Sentry. |
ivarnakken
force-pushed
the
event-serializers-and-views-improvements
branch
2 times, most recently
from
62f857e to
8ed9675
Compare
More consistent across different api calls to prevent "glitches" when switching between pages that use different event serializers (such as /events and /events/<pk>).
ivarnakken
force-pushed
the
event-serializers-and-views-improvements
branch
from
8ed9675 to
74b926b
Compare
norbye
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3697 was a little rushed so that I could test webkom/lego-webapp#5230 with better staging data - here's the clean up :)