Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include user reg to events in event list #3697

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ivarnakken
Copy link
Member

Needed for ABA-1196

@ivarnakken ivarnakken added new-feature Pull requests that introduce or issues that suggest a new feature review-needed Pull requests that need review small-fix Pull requests that fix something small labels Dec 11, 2024
@ivarnakken ivarnakken requested a review from a team December 11, 2024 12:51
@ivarnakken ivarnakken self-assigned this Dec 11, 2024
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you should probably check if we are using prefetching for this query and add this if so:)

@ivarnakken
Copy link
Member Author

Looks good, you should probably check if we are using prefetching for this query and add this if so:)

Already implemented! Excellent code 😎
https://github.com/webkom/lego/blob/master/lego/apps/events/views.py#L129-L135

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (6dbdcfd) to head (01bf627).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3697   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         700      700           
  Lines       22425    22430    +5     
=======================================
+ Hits        20094    20099    +5     
  Misses       2331     2331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivarnakken ivarnakken merged commit c52c6f1 into master Dec 11, 2024
3 checks passed
@ivarnakken ivarnakken deleted the include-user-reg-to-event-list branch December 11, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved new-feature Pull requests that introduce or issues that suggest a new feature review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants