Include registration statuses to event items #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`userReg` is now included in the read event `ListEvent` model
Makes it easier to differentiate between the list of dates in the items. Besides, people prefer to use the event list on /events rather than the one on the user profile to view upcoming events.
In case the user is on the /events page and logs in, the events should be re-fetched to get the user registration statuses.
ivarnakken
added
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
norbye
approved these changes
Dec 12, 2024
ivarnakken
deleted the
ivarnakken/aba-1196-differentiate-between-dates-on-compact-events-better
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes it much easier to differentiate between the list of dates in the items.
There's no need to show the activation time for registrations if the user has
already registered.
Besides, people prefer to use the event list on /events rather than the
one on the user profile to view upcoming events.
Result
Look at Deloitte AS and Fadderpåmelding Kommunikasjonsteknologi to see event items with 2 dates ... difficult to differentiate between the two:
Testing
Tested all event types, and the three different registration statuses (unregistered, waiting list and registered/admitted)