Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 2.x scrypt shim of web3-eth-accounts with https://github.com/web3-js/scrypt-shim #3036

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Replace 2.x scrypt shim of web3-eth-accounts with https://github.com/web3-js/scrypt-shim #3036

merged 2 commits into from
Sep 5, 2019

Conversation

michaelsbradleyjr
Copy link
Contributor

No description provided.

@nivida nivida added 2.x 2.0 related issues Bug Addressing a bug In Progress Currently being worked on labels Aug 16, 2019
@nivida nivida mentioned this pull request Aug 16, 2019
Closed
@coveralls
Copy link

coveralls commented Aug 16, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 95.944% when pulling 094d4d0 on michaelsbradleyjr:refactor/2.x-scrypt-shim into 1baa676 on ethereum:2.x.

@michaelsbradleyjr michaelsbradleyjr mentioned this pull request Aug 26, 2019
Closed
@michaelsbradleyjr
Copy link
Contributor Author

See: #3035 (comment).

@nivida nivida removed the In Progress Currently being worked on label Sep 5, 2019
@nivida nivida merged commit 62f78f5 into web3:2.x Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

Assignees
No one assigned
Labels
2.x 2.0 related issues Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelsbradleyjr @coveralls @nivida