Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using IIFE to require scrypt #3026

Closed
wants to merge 2 commits into from

Conversation

ppoliani
Copy link

This should fix #3018

@coveralls
Copy link

coveralls commented Aug 14, 2019

Coverage Status

Coverage remained the same at 83.191% when pulling ca845c6 on ppoliani:ch-use-static-import into 2d0a3f3 on ethereum:1.x.

@ppoliani
Copy link
Author

Not sure why the build fails. All tests seem to pass. Is there something that is missing?

@michaelsbradleyjr
Copy link
Contributor

michaelsbradleyjr commented Aug 14, 2019

@ppoliani the current build pipeline doesn't deal well with static require in reference to a package that may be supplied by the person who installed it alongside web3, i.e. the scrypt package is no longer a dependency of web3 itself. That's why I introduced the dynamic require. The webpack warning that introduces doesn't cause builds to fail strictly speaking; however some developers' build pipelines may be setup to fail outright even on a warning.

See: #2938 (comment).

A better solution is in the works, hopefully I'll get the PR up tomorrow.

@nivida
Copy link
Contributor

nivida commented Aug 16, 2019

Closed because of the newly opened PR‘s: #3036 #3035

@nivida nivida closed this Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants