Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 1.x scrypt shim of web3-eth-accounts with https://github.com/web3-js/scrypt-shim #3035

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

michaelsbradleyjr
Copy link
Contributor

@michaelsbradleyjr michaelsbradleyjr commented Aug 16, 2019

Fixes #3018

@coveralls
Copy link

coveralls commented Aug 16, 2019

Coverage Status

Coverage decreased (-0.07%) to 83.117% when pulling fea7a9b on michaelsbradleyjr:refactor/1.x-scrypt-shim into 7d1b0ea on ethereum:1.x.

@nivida nivida added 1.x 1.0 related issues Bug Addressing a bug In Progress Currently being worked on labels Aug 16, 2019
@michaelsbradleyjr
Copy link
Contributor Author

michaelsbradleyjr commented Aug 28, 2019

I'm working toward a PR that will further improve the web3-js/scrypt-shim package, should be done soon; hopefully today, maybe tomorrow.

Also, I need to do an experiment, but I'm fairly certain already that the present strategy in web3 to point to "rolling updates" branches on GitHub for web3-js/WebSocket-Node and web3-js/scrypt-shim is somewhat flawed. That is, I believe web3 users' package-lock.json or yarn.lock files pin to a specific commit and then later updates will require manual intervention (in the lockfiles!). Instead, I think those packages should be published on the registry, scoped as @web3-js or whatever is appropriate/possible, and when changes are made to them new versions should be published as usual. If we want to stick with pointing to GitHub for those packages, then I believe we should use tags in the github: specifiers rather than a branch name that's always the same, i.e. a new tag can be created when there's an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants